-
Notifications
You must be signed in to change notification settings - Fork 18
Fixing reply_regex to match current response #12
base: master
Are you sure you want to change the base?
Conversation
This fixes lack of progress, possibly caused by newer firmware
|
Hey @darek-margas, thanks for the PR. Can you tell me which printer and which firmware this is specifically for? I saw your comment in another issue mentioning a new firmware version which started returning information about layers. My Adventurer 3 is on the newest 1.3.6 firmware, and the response after sending meaning this PR would fix it for a different printer but would also break it for Adventurer 3. I'm happy to make this integration more compatible, but with maintaining backwards compatibility and ensuring it works on Adventurer 3. Can you tell me which printer are you using and with which firmware version? |
|
Hey @darek-margas, thanks for helping with solving this issue! I opted for a slightly different approach in af60c8c which makes it compatible with both Adventurer 3 and 4. Let me know if it works for you 🙂 |
Changes to let it co-exist.
Added layers to attributes
Room for printer details
Trying to handle ConfigEntryNotReady
Fix for handling config error exception
Improved regex
This fixes lack of progress, possibly caused by newer firmware