Skip to content

Conversation

0x0a0d
Copy link
Contributor

@0x0a0d 0x0a0d commented Oct 25, 2023

Limitation in the mergeSchemaSettings function (service.js#L668), where the default moleculer-db setting's entry value was set to null, preventing it from being overridden by other mixins.

By changing the default entry value to undefined, it now aligns with Lodash’s defaultsDeep method, which prioritizes values that are not undefined

… that permit its overwrite from other mixins.
@icebob
Copy link
Member

icebob commented Nov 12, 2023

You can overwrite these values as well, just you should reorder the mixins

@0x0a0d
Copy link
Contributor Author

0x0a0d commented Nov 12, 2023

I think it is better to change null to undefined. You can bump the minor version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants