Bugfix: Error printing lists of values #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed a problem printing varaibles that were a list of floats.
There was a problem hiding this comment.
Pull Request Overview
The PR fixes an issue where lists of float values were not printed correctly by converting each value to its string representation before printing.
- Updated the docstring format in control_parameters_parameters.py
- Fixed the printing of list values in control_parameters.py by converting floats to strings
- Updated HISTORY.rst to log the bugfix (note the spelling error in "varaibles")
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| control_parameters_step/control_parameters_parameters.py | Reformatted the docstring for clarity |
| control_parameters_step/control_parameters.py | Added conversion of list elements to strings for printing |
| HISTORY.rst | Added log entry of bugfix with a spelling mistake |
Comments suppressed due to low confidence (1)
control_parameters_step/control_parameters.py:349
- [nitpick] Consider renaming 'tmp' to a more descriptive name (e.g., 'string_values') to clearly reflect its purpose.
tmp = [str(v) for v in value]
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
seamm
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.