feat(save-user-data): extend user data abstract class for api backend COMPASS-9558 #7114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'user-data-interface' of https://github.com/mongodb-js/compass into user-data-interface
Merge branch 'extend-user-data' of https://github.com/mongodb-js/compass into extend-user-data
gribnoysup
reviewed
Jul 16, 2025
gribnoysup
reviewed
Jul 16, 2025
gribnoysup
reviewed
Jul 16, 2025
Anemy
reviewed
Jul 17, 2025
myang1220
commented
Jul 18, 2025
| } | ||
|
|
||
| return true; | ||
| } catch (error) { |
There was a problem hiding this comment.
How does the logging look? Are there any changes that I should make to make this more consistent with Compass behavior?
myang1220
commented
Jul 18, 2025
myang1220
commented
Jul 18, 2025
myang1220
commented
Jul 18, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR extends the user data abstract class system by implementing a new AtlasUserData class that communicates with Atlas backend API endpoints for cloud-based user data storage, as an alternative to the existing file-based storage.
- Adds
AtlasUserDataclass implementing theIUserDatainterface for API-based storage - Includes comprehensive test coverage for all CRUD operations and URL construction
- Updates exports to make the new class available to consumers
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/compass-user-data/src/user-data.ts | Implements AtlasUserData class with HTTP-based CRUD operations |
| packages/compass-user-data/src/user-data.spec.ts | Adds comprehensive test suite for AtlasUserData functionality |
| packages/compass-user-data/src/index.ts | Exports the new AtlasUserData class |
Merge branch 'extend-user-data' of https://github.com/mongodb-js/compass into extend-user-data
gribnoysup
reviewed
Jul 21, 2025
Anemy
reviewed
Jul 22, 2025
Merge branch 'main' into extend-user-data
Merge branch 'extend-user-data' of https://github.com/mongodb-js/compass into extend-user-data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend the IUserData abstract class to create an AtlasUserData class that uses the endpoints created in CCS. Contains unit testing.
Checklist
Motivation and Context
Open Questions
See comments
Dependents
Types of changes