fix(mongodb-constants): add text.matchCriteria to template COMPASS-8601 #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
coverage: 72.884% (+0.3%) from 72.545% |
paula-stacho
force-pushed
the
COMPASS-8601
branch
from
11a2567 to
07ecdff
Compare
mabaasit
reviewed
Jul 9, 2025
| @@ -493,6 +493,16 @@ describe('devtools connect', function () { | |||
| ).to.equal(false); | |||
| }); | |||
|
|
|||
| it('returns false if the OIDC_CALLBACK is set', function () { | |||
There was a problem hiding this comment.
Is this test related to this ticket?
There was a problem hiding this comment.
No. The CI complained, it didn't make sense to add a test related to the template changes, so I added an unrelated test to please the gods of test coverage :D
lerouxb
reviewed
Jul 9, 2025
| @@ -493,6 +493,16 @@ describe('devtools connect', function () { | |||
| ).to.equal(false); | |||
| }); | |||
|
|
|||
| it('returns false if the OIDC_CALLBACK is set', function () { | |||
There was a problem hiding this comment.
The CI complained, it didn't make sense to add a test related to the template changes, so I added an unrelated test to please the gods of test coverage :D
lerouxb
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
COMPASS-8601
Adding new recommended option to the template https://www.mongodb.com/docs/atlas/atlas-search/text/. 'any' is the default.
Open Questions
Checklist