-
Notifications
You must be signed in to change notification settings - Fork 80
feat(deps): bump oidc-plugin to 2.0.0 MONGOSH-2194 #2500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 2a2c6df.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates several MongoDB development tools dependencies, primarily bumping the OIDC plugin to version 2.0.0 and related devtools packages. The changes ensure compatibility across the mongosh ecosystem and address a behavioral change in the devtools-connect library regarding connection ping behavior.
- Updates @mongodb-js/oidc-plugin from ^1.1.8 to ^2.0.1 across multiple packages
- Bumps @mongodb-js/devtools-connect from ^3.4.1 to ^3.9.2 in several packages
- Updates @mongodb-js/devtools-proxy-support from ^0.4.2 to ^0.5.1
- Restores mongosh's existing ping behavior by explicitly setting __skipPingOnConnect to false
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/types/package.json | Updates devtools-connect dependency |
packages/snippet-manager/package.json | Updates devtools-proxy-support dependency |
packages/service-provider-node-driver/src/node-driver-service-provider.ts | Adds __skipPingOnConnect configuration with detailed explanation |
packages/service-provider-node-driver/package.json | Updates devtools-connect and oidc-plugin dependencies |
packages/logging/package.json | Updates devtools-connect dependency |
packages/e2e-tests/package.json | Updates oidc-plugin dependency |
packages/cli-repl/package.json | Updates devtools-proxy-support dependency |
packages/arg-parser/package.json | Updates devtools-connect dependency |
// flag to `false` here restores mongosh's existing behavior, and we can | ||
// revisit this in the next major version of mongosh. | ||
__skipPingOnConnect: false, | ||
} as MongoClientOptions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbbeeken fyi
No description provided.