Skip to content

Use newest versions of PHPUnitBridge #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Use newest versions of PHPUnitBridge #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"symfony/browser-kit": "^6.3 || ^7.0",
"symfony/filesystem": "^6.3 || ^7.0",
"symfony/framework-bundle": "^6.3.5 || ^7.0",
"symfony/phpunit-bridge": "^6.3 || ^7.0",
"symfony/phpunit-bridge": "~6.3.10 || ^6.4.1 || ^7.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason to user ~ over ^?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want 6.4.0 to be installed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand 6.4.0 can never be installed due to the second version definition ^6.4.1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://getcomposer.org/doc/articles/versions.md#next-significant-release-operators

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but then the second kicks in, np?

It would be simpler to read like this:
^6.3.10 || ^7.0.1

adding a conflict for =6.4.0

"symfony/yaml": "^6.3 || ^7.0",
"zenstruck/browser": "^1.6"
},
Expand Down