[LG-5293] feat: ContextDrawer #2918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c1cb077 The changes in this PR will be included in the next version bump. This PR includes changesets to release 85 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stephl3
changed the title
|
Size Change: +134 B (+0.01%) Total Size: 1.88 MB
ℹ️ View Unchanged
|
tsck
approved these changes
Jun 26, 2025
| import { getFill, getWrapperStyles } from './ButtonCorner.styles'; | ||
| import { Side } from './ButtonCorner.types'; | ||
|
|
||
| export const ButtonCorner = ({ side }: { side: Side }) => { |
There was a problem hiding this comment.
Nit: took me a sec to get what a button corner was, had to look at how it was used. Perhaps a small comment as simple as "visually rounded sides of the ContextDrawerButton" would make this super clear at a glance.
Comment on lines
+17
to
+28
| &:focus-visible { | ||
| background-color: ${backgroundColor}; | ||
| color: ${textColor}; | ||
| box-shadow: none; | ||
| } | ||
|
|
||
| &:hover, | ||
| &:active { | ||
| background-color: ${backgroundColor}; | ||
| color: ${textColor}; | ||
| box-shadow: none; | ||
| } |
There was a problem hiding this comment.
Q: We don't want anything to change visually on focus or hover? Any reason why?
There was a problem hiding this comment.
this is according to the design specs here: https://www.figma.com/design/4h2VwjCuJUbeZ7hzD2J1rq/LeafyGreen-Design-System?m=auto&node-id=41064-134808
I explicitly set these here to reset the styling applied in LG button
…y for styling ContextDrawerButton
stephl3
force-pushed
the
steph/ipl-context-drawer
branch
from
a8b8a28 to
a9c690b
Compare
* chore(context-drawer): update dependencies * fix(context-drawer): ContextDrawerButton glyph rotates * feat(context-drawer): implement ContextDrawer component with stories and specs * docs(context-drawer): README * fix(ContextDrawerButton): styling * refactor(ContextDrawer): hardcode additional spacing for bottomInterceptRef * style(ContextDrawer): improve visibility transition and collapse reference border * docs(context-drawer): README format * refactor(context-drawer): tab navigation with specs * update spec * Reduce redundant css selector specificity * feat(lib): add formatCssSize util (#2930) * feat(lib): add formatCssSize util * refactor(ContextDrawer): formatCssSize on expandedHeight * chore(lib): changeset * refactor(lib): formatCssSize trims string values before format * refactor(lib): formatCssSize types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR covers part 1 of the
ContextDrawer:@leafygreen-ui/context-drawerpackageContextDrawerButtoncomponentButtonCornercomponent🎟 Jira ticket: LG-5293
✅ Checklist
For new components
🧪 How to test changes
Components/ContextDrawer/ContextDrawerButtonlive example storyComponents/ContextDrawer/ContextDrawerButtongenerated stories