refactor(DrawerToolbarLayout): update timeout #3019
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * can drag the drawer and it snaps shut * comments * add todos * keyboard interaction * update keyboard logic to work with handle position * remove css transition from within hook * change drawer onChange type * fix handleType issues * fix some TS errors * remove handlerType from getResizerProps * remove size obj * some more cleanup * remove dup code * fix some TS errors * remove snap close logic * create DrawerLayoutContext * fix weird transition * remove error in file * fix open and resizable checks * add top and bottom support * make getKeyboardInteraction DRYer * add useResizable story * all tests are passing * update useResizable tests * rename handleType to dragFrom * add comments to useResizable * create a utils folder for useResizable * only prevent default when arrow keys are pressed * update types * aria-value updates on resize * add className to getResizerProps * update body cursor on resize * remove comment * rename dragFrom to position * fix failing tests * remove comments * lint * lint and clean up * move useResizable hook to hook package * revert drawer changes * fix build error, improve useResizable utility functions * update pnpm-lock * update tsdocs * lint * reorganize and update types * remove defaults from minSize and maxSize * use enum values for SIZE_GROWTH_KEY_MAPPINGS * add util folder * move calculateNewSize to utils * move getNextKeyboardSize to utils * update tests * lint * move updateSize function * add comments * fix ketboard decrease bug * move utils to util folder * fix validate error * update lockfile * move hook to a package * update lock file * remove palette from hooks
* wip * can drag the drawer and it snaps shut * comments * add todos * keyboard interaction * update keyboard logic to work with handle position * remove css transition from within hook * change drawer onChange type * fix handleType issues * fix some TS errors * remove handlerType from getResizerProps * remove size obj * some more cleanup * remove dup code * fix some TS errors * remove snap close logic * create DrawerLayoutContext * fix weird transition * remove error in file * fix open and resizable checks * add top and bottom support * make getKeyboardInteraction DRYer * add useResizable story * all tests are passing * update useResizable tests * rename handleType to dragFrom * add comments to useResizable * create a utils folder for useResizable * only prevent default when arrow keys are pressed * update types * aria-value updates on resize * add className to getResizerProps * update body cursor on resize * remove comment * rename dragFrom to position * fix failing tests * remove comments * lint * lint and clean up * move useResizable hook to hook package * revert drawer changes * extract drawer changes from resizable hook branch * clean up DrawerLayout types * update types and rename some consts * organize toolbar styles better * some more cleanup * lint * fix build error, improve useResizable utility functions * update pnpm-lock * update tsdocs * lint * fix embedded animation * lint * fix DrawerLayout.spec * update tsdocs and refactor DrawerToolbarLayout stories * clean up drawer.tsx * remove drawer check * update Drawer story open prop * isOverLay to isOverlay * remove TOOLBAR_WIDTH export * unify transition duration and timing function across components * remove resizableRef check * create setIsDrawerOpen to update value within components * fix failing test in DrawerLayoutContext * use css vars * update CSS var * add defaults * lint * add resolvedProp hooks * remove check in LayoutComponent * add more tests to DrawerLayoutContext and update spec file * fix build error * update css var * fix failing test * set a default for --drawer-width * story ts error * fix story ts error * trigger checks * reorganize and update types * remove defaults from minSize and maxSize * use enum values for SIZE_GROWTH_KEY_MAPPINGS * add util folder * move calculateNewSize to utils * move getNextKeyboardSize to utils * update tests * lint * move updateSize function * add comments * fix ketboard decrease bug * move utils to util folder * fix validate error * update lockfile * move hook to a package * update lock file * remove palette from hooks * use resizable package * lint
* wip * can drag the drawer and it snaps shut * comments * add todos * keyboard interaction * update keyboard logic to work with handle position * remove css transition from within hook * change drawer onChange type * fix handleType issues * fix some TS errors * remove handlerType from getResizerProps * remove size obj * some more cleanup * remove dup code * fix some TS errors * remove snap close logic * create DrawerLayoutContext * fix weird transition * remove error in file * fix open and resizable checks * add top and bottom support * make getKeyboardInteraction DRYer * add useResizable story * all tests are passing * update useResizable tests * rename handleType to dragFrom * add comments to useResizable * create a utils folder for useResizable * only prevent default when arrow keys are pressed * update types * aria-value updates on resize * add className to getResizerProps * update body cursor on resize * remove comment * rename dragFrom to position * fix failing tests * remove comments * lint * lint and clean up * move useResizable hook to hook package * revert drawer changes * extract drawer changes from resizable hook branch * clean up DrawerLayout types * update types and rename some consts * organize toolbar styles better * some more cleanup * lint * fix build error, improve useResizable utility functions * update pnpm-lock * update tsdocs * lint * fix embedded animation * lint * fix DrawerLayout.spec * update tsdocs and refactor DrawerToolbarLayout stories * clean up drawer.tsx * remove drawer check * update Drawer story open prop * isOverLay to isOverlay * remove TOOLBAR_WIDTH export * unify transition duration and timing function across components * remove resizableRef check * create setIsDrawerOpen to update value within components * fix failing test in DrawerLayoutContext * use css vars * update CSS var * add defaults * lint * add resolvedProp hooks * remove check in LayoutComponent * add more tests to DrawerLayoutContext and update spec file * fix build error * update css var * fix failing test * set a default for --drawer-width * story ts error * fix story ts error * trigger checks * add size prop to drawer * update stories and update sizes * lint * update Drawer prop table * testing * remove testing comments * remove type from Size export * update README to included sizes * remove DRAWER_MAX_PERCENTAGE_WIDTH and update getResolvedDrawerSizes * remove drawer.constants and updates DRAWER_WIDTH * remove palette from hooks
* wip * can drag the drawer and it snaps shut * comments * add todos * keyboard interaction * update keyboard logic to work with handle position * remove css transition from within hook * change drawer onChange type * fix handleType issues * fix some TS errors * remove handlerType from getResizerProps * remove size obj * some more cleanup * remove dup code * fix some TS errors * remove snap close logic * create DrawerLayoutContext * fix weird transition * remove error in file * fix open and resizable checks * add top and bottom support * make getKeyboardInteraction DRYer * add useResizable story * all tests are passing * update useResizable tests * rename handleType to dragFrom * add comments to useResizable * create a utils folder for useResizable * only prevent default when arrow keys are pressed * update types * aria-value updates on resize * add className to getResizerProps * update body cursor on resize * remove comment * rename dragFrom to position * fix failing tests * remove comments * lint * lint and clean up * move useResizable hook to hook package * revert drawer changes * extract drawer changes from resizable hook branch * clean up DrawerLayout types * update types and rename some consts * organize toolbar styles better * some more cleanup * lint * fix build error, improve useResizable utility functions * update pnpm-lock * update tsdocs * lint * fix embedded animation * lint * fix DrawerLayout.spec * update tsdocs and refactor DrawerToolbarLayout stories * clean up drawer.tsx * remove drawer check * update Drawer story open prop * isOverLay to isOverlay * remove TOOLBAR_WIDTH export * unify transition duration and timing function across components * remove resizableRef check * create setIsDrawerOpen to update value within components * fix failing test in DrawerLayoutContext * use css vars * update CSS var * add defaults * lint * add resolvedProp hooks * remove check in LayoutComponent * add more tests to DrawerLayoutContext and update spec file * fix build error * update css var * fix failing test * set a default for --drawer-width * story ts error * fix story ts error * trigger checks * reorganize and update types * remove defaults from minSize and maxSize * add size prop to drawer * use enum values for SIZE_GROWTH_KEY_MAPPINGS * add util folder * move calculateNewSize to utils * move getNextKeyboardSize to utils * update tests * lint * move updateSize function * add comments * update stories and update sizes * lint * update Drawer prop table * fix ketboard decrease bug * move utils to util folder * fix validate error * update lockfile * move hook to a package * update lock file * remove palette from hooks * use resizable package * lint * show toolbar focus and disable keydown on blur * remove conditional initial size passed to initialSize * testing * remove testing comments * remove type from Size export * update README to included sizes * remove DRAWER_MAX_PERCENTAGE_WIDTH and update getResolvedDrawerSizes * use var for padding hack * remove keyMap from hook spec * remove keydown on window * update comments * remove constants file * feedback
…rawer directory (#3009) * wip * can drag the drawer and it snaps shut * comments * add todos * keyboard interaction * update keyboard logic to work with handle position * remove css transition from within hook * change drawer onChange type * fix handleType issues * fix some TS errors * remove handlerType from getResizerProps * remove size obj * some more cleanup * remove dup code * fix some TS errors * remove snap close logic * create DrawerLayoutContext * fix weird transition * remove error in file * fix open and resizable checks * add top and bottom support * make getKeyboardInteraction DRYer * add useResizable story * all tests are passing * update useResizable tests * rename handleType to dragFrom * add comments to useResizable * create a utils folder for useResizable * only prevent default when arrow keys are pressed * update types * aria-value updates on resize * add className to getResizerProps * update body cursor on resize * remove comment * rename dragFrom to position * fix failing tests * remove comments * lint * lint and clean up * move useResizable hook to hook package * revert drawer changes * extract drawer changes from resizable hook branch * clean up DrawerLayout types * update types and rename some consts * organize toolbar styles better * some more cleanup * lint * fix build error, improve useResizable utility functions * update pnpm-lock * update tsdocs * lint * fix embedded animation * lint * fix DrawerLayout.spec * update tsdocs and refactor DrawerToolbarLayout stories * clean up drawer.tsx * remove drawer check * update Drawer story open prop * isOverLay to isOverlay * remove TOOLBAR_WIDTH export * unify transition duration and timing function across components * remove resizableRef check * create setIsDrawerOpen to update value within components * fix failing test in DrawerLayoutContext * use css vars * update CSS var * add defaults * lint * add resolvedProp hooks * remove check in LayoutComponent * add more tests to DrawerLayoutContext and update spec file * fix build error * update css var * fix failing test * set a default for --drawer-width * story ts error * fix story ts error * trigger checks * reorganize and update types * remove defaults from minSize and maxSize * add size prop to drawer * use enum values for SIZE_GROWTH_KEY_MAPPINGS * add util folder * move calculateNewSize to utils * move getNextKeyboardSize to utils * update tests * lint * move updateSize function * add comments * update stories and update sizes * lint * update Drawer prop table * fix ketboard decrease bug * move utils to util folder * fix validate error * update lockfile * move hook to a package * update lock file * remove palette from hooks * use resizable package * lint * show toolbar focus and disable keydown on blur * remove conditional initial size passed to initialSize * testing * remove testing comments * remove type from Size export * update README to included sizes * remove DRAWER_MAX_PERCENTAGE_WIDTH and update getResolvedDrawerSizes * use var for padding hack * remove keyMap from hook spec * remove keydown on window * update comments * remove constants file * add resizable README * update drawer README * fix tyypo * more updates * more updates * clean up drawer README * move DrawerToolbarContext and DrawerWithToolbarWrapper inside DrawerToolbarLayout directory * move EmbeddedDrawerLayout and OverlayDrawerLayout inside LayoutComponent directory * rename DrawerToolbarLayoutContainer to DrawerToolbarLayoutContent * add Resizable changeset * add drawer changeset * add backward compatible * add more tests to DrawerLayout * refactor(drawer): add some more tests and extract test utils * create DrawerToolbarLayout directory * change from major to minor change * copilot feedback
|
|
Size Change: 0 B Total Size: 1.98 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR is to fix the flaky drawer toolbar interaction tests.
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes