-
Notifications
You must be signed in to change notification settings - Fork 69
[LG-5094] feat(code-editor): add panel component for toolbar functionality #3047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tsck
wants to merge
21
commits into
integration/code-editor
Choose a base branch
from
LG-5094/cs-toolbar-panel
base: integration/code-editor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
a493776
feat(CodeEditor): enhance copy button functionality and styling
tsck 705f5de
refactor(CodeEditor): remove unused import from CodeEditor.types.ts
tsck 20e4ba3
feat(CodeEditor): add CodeEditorContext for internal state management
tsck fcaa74a
feat(CodeEditor): introduce Panel component for enhanced toolbar func…
tsck 740b9db
changeset
tsck 72f1988
fix(Panel): disable dark menu rendering in the Panel component
tsck 85ccbf0
feat(CodeEditor): integrate Panel component and enhance CodeEditor fu…
tsck e8dbc88
refactor(CodeEditor, Panel): reorganize props for improved clarity an…
tsck 3d2670d
docs(CodeEditor): update README to include new `panel` prop details
tsck 76c646d
test(Panel): add comprehensive unit tests for Panel component functio…
tsck 2d03e1c
Updated changeset
tsck 288c313
feat(CodeEditorCopyButton): enhance icon fill color handling and simp…
tsck 60ab5b4
refactor(CodeEditor): rename getContents prop for clarity
tsck 3bfad7c
feat(CodeEditor): enhance copy button functionality and styling
tsck d0978ea
refactor(CodeEditor): remove unused import from CodeEditor.types.ts
tsck 665a0f1
refactor(CodeEditor): rename getContents prop to getContentsToCopy
tsck cb12287
docs(CodeEditor): add SecondaryButtonConfig section to README
tsck a3b0f25
fix(Panel): update copy button accessibility labels in tests
tsck 7da72c8
refactor(Panel): update panel styles for consistency and clarity
tsck d551e73
feat(Panel): add support for custom secondary button properties
tsck bc925b7
fix(CodeEditor): remove href from custom secondary button configuration
tsck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- | ||
'@leafygreen-ui/code-editor': minor | ||
--- | ||
|
||
Adds **Panel component**: A comprehensive toolbar interface for CodeEditor with formatting, copying, and custom action buttons | ||
|
||
- **New Panel component**: Provides a configurable toolbar that displays at the top of CodeEditor | ||
- **Built-in actions**: Includes format button, copy button, and secondary menu with undo/redo/download/shortcuts | ||
- **Customizable**: Supports custom secondary buttons and inner content for application-specific needs | ||
- **Fully accessible**: All buttons and menu items include proper ARIA labels and keyboard navigation | ||
- **Context integration**: Seamlessly integrates with CodeEditor context for copy functionality | ||
- **Styling**: Matches CodeEditor theme with proper grid layout and responsive design | ||
|
||
The Panel component enhances the CodeEditor user experience by providing easy access to common editor actions through a clean, organized interface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about adding a note about what functionality is provided out-of-the-box vs what consumers will need to implement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, will all of these actions be supported out-of-the-box? (I might be incorrectly assuming based off of having only reviewed copy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, all of these actions will be provided! Only added secondary actions won't be.