-
Notifications
You must be signed in to change notification settings - Fork 69
Adds and exports test harnesses from SplitButton component #3055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bruugey
wants to merge
11
commits into
main
Choose a base branch
from
brooke/split-button-harness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3b4b46e
Adds test harnesses to SplitButton component
bruugey d4c963f
Update packages/split-button/src/testing/getTestUtils.ts
bruugey f6e0488
Update packages/split-button/src/testing/getTestUtils.ts
bruugey 35826f5
Update packages/split-button/src/testing/getTestUtils.ts
bruugey eb062c4
Update packages/split-button/src/testing/getTestUtils.ts
bruugey 6a7e113
re-run init and fix config
bruugey bbf2fd4
with changesets
bruugey 461192f
Merge branch 'main' into brooke/split-button-harness
bruugey 2db8f8a
Merge remote-tracking branch 'origin' into brooke/split-button-harness
bruugey 60378aa
update local package.json
bruugey f53b3c9
updates lock file
bruugey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@leafygreen-ui/split-button': minor | ||
--- | ||
|
||
Adds and exports test harnesses from SplitButton package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -33,12 +33,14 @@ | |||
"@leafygreen-ui/palette": "workspace:^", | ||||
"@leafygreen-ui/polymorphic": "workspace:^", | ||||
"@leafygreen-ui/popover": "workspace:^", | ||||
"@leafygreen-ui/tokens": "workspace:^" | ||||
"@leafygreen-ui/tokens": "workspace:^", | ||||
"@lg-tools/test-harnesses": "workspace:^" | ||||
}, | ||||
"peerDependencies": { | ||||
"@leafygreen-ui/leafygreen-provider": "workspace:^" | ||||
}, | ||||
"devDependencies": { | ||||
"@lg-tools/build": "workspace:^" | ||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
} | ||||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to add an
exports
key to this file so consumers can access the test utils