Skip to content

Conversation

matthewdale
Copy link
Collaborator

@matthewdale matthewdale commented Aug 29, 2025

Summary

Retry Markdown link checks when the endpoint responds with HTTP 429.

Background & Motivation

The http://reneefrench.blogspot.com/ site returns HTTP 429 frequently, leading to failed pre-commit checks when run in the Github Actions runners. The markdown-link-check tool supports retrying after an HTTP 429, automatically waiting until the time specified by the "retry-after" HTTP header. See the usage docs for details.

@github-actions github-actions bot added the review-priority-normal Medium Priority PR for Review: within 1 business day label Aug 29, 2025
Copy link
Contributor

🧪 Performance Results

Commit SHA: 58e700a

The following benchmark tests for version 68b1d98d76cdc90007376ad7 had statistically significant changes (i.e., |z-score| > 1.96):

Benchmark Measurement % Change Patch Value Stable Region H-Score Z-Score
BenchmarkSingleRunCommand ops_per_second_min 32.7993 1921.9903 Avg: 1447.2894
Med: 1458.7797
Stdev: 171.8112
0.8047 2.7629
BenchmarkBSONDeepDocumentDecoding ops_per_second_min 15.3054 2283.2406 Avg: 1980.1684
Med: 1988.0834
Stdev: 121.8239
0.7766 2.4878
BenchmarkSmallDocInsertOne total_time_seconds -5.0704 1.1240 Avg: 1.1840
Med: 1.1850
Stdev: 0.0219
0.8008 -2.7460
BenchmarkSingleFindOneByID ops_per_second_max 3.7061 4620.0687 Avg: 4454.9644
Med: 4451.5075
Stdev: 79.5812
0.7585 2.0747
BenchmarkBSONDeepDocumentDecoding total_time_seconds 1.4991 1.2172 Avg: 1.1992
Med: 1.1989
Stdev: 0.0058
0.8429 3.0836
BenchmarkBSONFullDocumentEncoding allocated_bytes_per_op 0.0886 5207.0000 Avg: 5202.3895
Med: 5202.0000
Stdev: 2.0384
0.7601 2.2618

For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch.

Copy link
Contributor

API Change Report

No changes found!

@matthewdale matthewdale marked this pull request as ready for review August 29, 2025 16:54
@Copilot Copilot AI review requested due to automatic review settings August 29, 2025 16:54
@matthewdale matthewdale requested a review from a team as a code owner August 29, 2025 16:54
Copilot

This comment was marked as outdated.

@matthewdale matthewdale requested a review from Copilot August 29, 2025 16:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds retry functionality to the markdown link checker to handle HTTP 429 "Too Many Requests" responses, specifically addressing frequent failures from http://reneefrench.blogspot.com/ during pre-commit checks in GitHub Actions.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@matthewdale matthewdale requested review from prestonvasquez and removed request for qingyang-hu August 29, 2025 16:55
@matthewdale matthewdale enabled auto-merge (squash) August 29, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ignore-for-release review-priority-normal Medium Priority PR for Review: within 1 business day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant