PHPC-2638 and PHPC-2630: Bump to libmongoc 2.1.2 and libmongocrypt 1.16.0 #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Sep 15, 2025
jmikola
changed the title
jmikola
force-pushed
the
phpc-2611-libmongoc-2.1
branch
from
7fe0f9e to
3f7be27
Compare
alcaeus
approved these changes
Sep 16, 2025
jmikola
force-pushed
the
phpc-2611-libmongoc-2.1
branch
2 times, most recently
from
990c7fe to
a79eab9
Compare
|
Note: we've got two regularly failing builds on Windows 8.4 x86 (nts and ts) due to:
The most recent failures are at mongoc-handshake.c:702 but I'm not sure how pertinent that is. Will come back to this and investigate further. |
Merged
jmikola
force-pushed
the
phpc-2611-libmongoc-2.1
branch
from
a79eab9 to
13515f7
Compare
jmikola
changed the title
This pulls in changes from MONGOCRYPT-845, which are necessary to produce a static build with both libmongoc 2.1.x and libmongocrypt (due to a conflict in the "mlib" headers).
jmikola
force-pushed
the
phpc-2611-libmongoc-2.1
branch
5 times, most recently
from
9126259 to
2f95be6
Compare
GromNaN
reviewed
Oct 14, 2025
jmikola
force-pushed
the
phpc-2611-libmongoc-2.1
branch
from
34eed62 to
7a3346a
Compare
jmikola
force-pushed
the
phpc-2611-libmongoc-2.1
branch
from
7a3346a to
e398106
Compare
jmikola
changed the title
GromNaN
reviewed
Oct 15, 2025
Comment on lines
+3
to
+5
| url = https://github.com/jmikola/mongo-c-driver.git | ||
| ignore = untracked | ||
| branch = 2.1.2-handshake |
There was a problem hiding this comment.
Is the fix you added on your branch necessary for this PR?
There was a problem hiding this comment.
I'm still attempting to isolate the OOM compiler error in order to provide meaningful feedback to the C team. It's likely this is the result of ludicrous macro expansion in their BSON DSL (see mongoc-handshake.c in mongodb/mongo-c-driver@f142c61).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2638
https://jira.mongodb.org/browse/PHPC-2630
The libmongocrypt upgrade is necessary due to a collision between "mlib" headers in libmongoc and libmongocrypt (addressed in MONGOCRYPT-845).