Skip to content

PYTHON-5315 Mark test_recover_from_initially_erroring_seedlist as flaky #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/asynchronous/test_cursor.py
Original file line number Diff line number Diff line change
Expand Up @@ -1411,7 +1411,7 @@ async def test_to_list_length(self):
async def test_to_list_csot_applied(self):
client = await self.async_single_client(timeoutMS=500, w=1)
coll = client.pymongo.test
# Initialize the client with a larger timeout to help make test less flakey
# Initialize the client with a larger timeout to help make test less flaky
with pymongo.timeout(10):
await coll.insert_many([{} for _ in range(5)])
cursor = coll.find({"$where": delay(1)})
Expand Down Expand Up @@ -1453,7 +1453,7 @@ async def test_command_cursor_to_list_length(self):
async def test_command_cursor_to_list_csot_applied(self):
client = await self.async_single_client(timeoutMS=500, w=1)
coll = client.pymongo.test
# Initialize the client with a larger timeout to help make test less flakey
# Initialize the client with a larger timeout to help make test less flaky
with pymongo.timeout(10):
await coll.insert_many([{} for _ in range(5)])
fail_command = {
Expand Down
2 changes: 1 addition & 1 deletion test/asynchronous/test_retryable_reads.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class TestPoolPausedError(AsyncIntegrationTest):
async def test_pool_paused_error_is_retryable(self):
if "PyPy" in sys.version:
# Tracked in PYTHON-3519
self.skipTest("Test is flakey on PyPy")
self.skipTest("Test is flaky on PyPy")
cmap_listener = CMAPListener()
cmd_listener = OvertCommandListener()
client = await self.async_rs_or_single_client(
Expand Down
1 change: 1 addition & 0 deletions test/asynchronous/test_srv_polling.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ def empty_seedlist():

await self._test_recover_from_initial(empty_seedlist)

@flaky(reason="PYTHON-5315")
async def test_recover_from_initially_erroring_seedlist(self):
def erroring_seedlist():
raise ConfigurationError
Expand Down
4 changes: 2 additions & 2 deletions test/test_cursor.py
Original file line number Diff line number Diff line change
Expand Up @@ -1402,7 +1402,7 @@ def test_to_list_length(self):
def test_to_list_csot_applied(self):
client = self.single_client(timeoutMS=500, w=1)
coll = client.pymongo.test
# Initialize the client with a larger timeout to help make test less flakey
# Initialize the client with a larger timeout to help make test less flaky
with pymongo.timeout(10):
coll.insert_many([{} for _ in range(5)])
cursor = coll.find({"$where": delay(1)})
Expand Down Expand Up @@ -1444,7 +1444,7 @@ def test_command_cursor_to_list_length(self):
def test_command_cursor_to_list_csot_applied(self):
client = self.single_client(timeoutMS=500, w=1)
coll = client.pymongo.test
# Initialize the client with a larger timeout to help make test less flakey
# Initialize the client with a larger timeout to help make test less flaky
with pymongo.timeout(10):
coll.insert_many([{} for _ in range(5)])
fail_command = {
Expand Down
2 changes: 1 addition & 1 deletion test/test_retryable_reads.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class TestPoolPausedError(IntegrationTest):
def test_pool_paused_error_is_retryable(self):
if "PyPy" in sys.version:
# Tracked in PYTHON-3519
self.skipTest("Test is flakey on PyPy")
self.skipTest("Test is flaky on PyPy")
cmap_listener = CMAPListener()
cmd_listener = OvertCommandListener()
client = self.rs_or_single_client(
Expand Down
1 change: 1 addition & 0 deletions test/test_srv_polling.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ def empty_seedlist():

self._test_recover_from_initial(empty_seedlist)

@flaky(reason="PYTHON-5315")
def test_recover_from_initially_erroring_seedlist(self):
def erroring_seedlist():
raise ConfigurationError
Expand Down
Loading