-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-4677 Specify how maxTimeMS can be set for explain helpers #2439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait JK just saw the test failures HAHA
test/asynchronous/test_cursor.py
Outdated
async def test_explain_csot(self): | ||
# Create a MongoClient with command monitoring enabled (referred to as client). | ||
listener = AllowListEventListener("explain") | ||
client = await self.rs_or_single_client(event_listeners=[listener]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this should be self.async_rs_or_single_client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I accidentally created the sync version first, then hand-ported it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.