remove WithLabels in BuildMongoDBReplicaSetStatefulSetModificationFun #1612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usernameisnull
requested review from
mircea-cosbuc,
lsierant,
slaskawi,
nammn and
Julien-Ben
as code owners
nammn
added
the
safe-to-test
|
This PR is being marked stale because it has been open for 60 days with no activity. Please update the PR or ask for a fresh review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ction
Summary:
the label of sts is set by statefulSet.metadata.labels, via https://github.com/mongodb/mongodb-kubernetes-operator/blob/8e1a37b82521d9c49f6862ecd8f20596b422fa5a/controllers/replica_set_controller.go#L746C1-L747C1
so no need to invoke WithLabels in BuildMongoDBReplicaSetStatefulSetModificationFun, it will be override anyway
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).