MONGOID-5890 Correct BSON::Decimal128 handling in normalize_value #6046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly use BSON::Decimal128#to_d if it is available in the driver
There was a problem hiding this comment.
Pull Request Overview
This PR improves the handling of BSON::Decimal128 values in the normalize_value method by preferring the native to_d method when available, falling back to string conversion for older driver versions.
- Updated normalize_value method to use BSON::Decimal128#to_d when available (driver v5.0.0+)
- Added fallback to BigDecimal(value.to_s) for backward compatibility with older driver versions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
johnnyshields
changed the title
comandeo-mongo
requested review from
comandeo-mongo
and removed request for
jamis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly use
BSON::Decimal128#to_dif it is available in the driver. Ensures backwards compatibility while avoiding future issues.Reasoning given here: #6042 (comment)
No additional tests needed as the test runs on different driver versions will suss this out.