Skip to content

chore: Non-transformed API spec resources (DO NOT MERGE) #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EspenAlbert
Copy link
Collaborator

Description

  • Looks at impact of using a unmodified API Spec with multple API versions per response and no transformations

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@EspenAlbert EspenAlbert changed the title chore: non-transformed API spec resources (DO NOT MERGE) chore: Non-transformed API spec resources (DO NOT MERGE) May 29, 2025
Required: true,
MarkdownDescription: "Name of the cloud provider region hosting Atlas Stream Processing.",
Attributes: map[string]schema.Attribute{},
Copy link
Collaborator Author

@EspenAlbert EspenAlbert May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty variables due to oneOf usage
image

VersionReleaseSystem types.String `tfsdk:"version_release_system"`
AcceptDataRisksAndForceReplicaSetReconfig types.String `tfsdk:"accept_data_risks_and_force_replica_set_reconfig"`
AdvancedConfiguration types.Object `tfsdk:"advanced_configuration"`
AutoScaling types.Object `tfsdk:"auto_scaling"`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined API versions makes for a big model

@@ -15,7 +15,10 @@ func GenerateSchemaAttributes(attrs codespec.Attributes) CodeStatement {
attrsCode = append(attrsCode, result.Code)
imports = append(imports, result.Imports...)
}
finalAttrs := strings.Join(attrsCode, ",\n") + ","
finalAttrs := strings.Join(attrsCode, ",\n")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix to allow empty attributes (happens due to oneOf)

Copy link
Contributor

github-actions bot commented Jun 4, 2025

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Jun 4, 2025
@EspenAlbert EspenAlbert added the not_stale Not stale issue or PR label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not_stale Not stale issue or PR stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant