-
Notifications
You must be signed in to change notification settings - Fork 203
chore: Non-transformed API spec resources (DO NOT MERGE) #3363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: Non-transformed API spec resources (DO NOT MERGE) #3363
Conversation
Required: true, | ||
MarkdownDescription: "Name of the cloud provider region hosting Atlas Stream Processing.", | ||
Attributes: map[string]schema.Attribute{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VersionReleaseSystem types.String `tfsdk:"version_release_system"` | ||
AcceptDataRisksAndForceReplicaSetReconfig types.String `tfsdk:"accept_data_risks_and_force_replica_set_reconfig"` | ||
AdvancedConfiguration types.Object `tfsdk:"advanced_configuration"` | ||
AutoScaling types.Object `tfsdk:"auto_scaling"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Combined API versions makes for a big model
@@ -15,7 +15,10 @@ func GenerateSchemaAttributes(attrs codespec.Attributes) CodeStatement { | |||
attrsCode = append(attrsCode, result.Code) | |||
imports = append(imports, result.Imports...) | |||
} | |||
finalAttrs := strings.Join(attrsCode, ",\n") + "," | |||
finalAttrs := strings.Join(attrsCode, ",\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fix to allow empty attributes (happens due to oneOf)
This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy! |
Description
Type of change:
Required Checklist:
Further comments