-
Notifications
You must be signed in to change notification settings - Fork 205
feat: Adds users
attribute to mongodbatlas_project
singular data source
#3439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
users
attribute to mongodbatlas_project
singular data source
@@ -528,14 +529,22 @@ func TestAccProject_basic(t *testing.T) { | |||
"is_realtime_performance_panel_enabled", | |||
"is_schema_advisor_enabled", | |||
} | |||
// Users check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -11,7 +11,7 @@ import ( | |||
"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion" | |||
) | |||
|
|||
func NewTFProjectDataSourceModel(ctx context.Context, project *admin.Group, projectProps AdditionalProperties) (*TFProjectDSModel, diag.Diagnostics) { | |||
func NewTFProjectDataSourceModel(ctx context.Context, project *admin.Group, projectProps *AdditionalProperties) (*TFProjectDSModel, diag.Diagnostics) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add checks here if project or projectProps are nil?
same in other methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in f2d5580
Great job!! Congrats on your first PR @csanx ! |
@@ -112,6 +112,17 @@ In addition to all arguments above, the following attributes are exported: | |||
* `services.clusters.#.inbound` - List of inbound IP addresses associated with the cluster. If your network allows outbound HTTP requests only to specific IP addresses, you must allow access to the following IP addresses so that your application can connect to your Atlas cluster. | |||
* `services.clusters.#.outbound` - List of outbound IP addresses associated with the cluster. If your network allows inbound HTTP requests only from specific IP addresses, you must allow access from the following IP addresses so that your Atlas cluster can communicate with your webhooks and KMS. | |||
|
|||
### Users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would make sure the descriptions are as aligned with the API spec as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
eaa4779
to
14e40d7
Compare
APIx bot: a message has been sent to Docs Slack channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for copy review
Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com>
var err error | ||
users, err = ListAllProjectUsers(ctx, projectID, mongoDBCloudUsersAPI) | ||
if err != nil { | ||
return nil, fmt.Errorf("error getting project's users (%s): %v", projectID, err.Error()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: You can use :=
short assignment statement to avoid the declaration of err
with explicit type
var err error | |
users, err = ListAllProjectUsers(ctx, projectID, mongoDBCloudUsersAPI) | |
if err != nil { | |
return nil, fmt.Errorf("error getting project's users (%s): %v", projectID, err.Error()) | |
users, err := ListAllProjectUsers(ctx, projectID, mongoDBCloudUsersAPI) | |
if err != nil { | |
return nil, fmt.Errorf("error getting project's users (%s): %v", projectID, err.Error()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
projectPropsParams := &PropsParams{ | ||
Context: ctx, | ||
IsDataSource: false, | ||
ProjectID: projectID, | ||
Warnings: &resp.Diagnostics, | ||
} | ||
|
||
projectApis := &APIClients{ | ||
ProjectsAPI: connV2.ProjectsApi, | ||
TeamsAPI: connV2.TeamsApi, | ||
PerformanceAdvisorAPI: connV2.PerformanceAdvisorApi, | ||
MongoDBCloudUsersAPI: connV2.MongoDBCloudUsersApi, | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
projectPropsParams := &PropsParams{ | |
Context: ctx, | |
IsDataSource: false, | |
ProjectID: projectID, | |
Warnings: &resp.Diagnostics, | |
} | |
projectApis := &APIClients{ | |
ProjectsAPI: connV2.ProjectsApi, | |
TeamsAPI: connV2.TeamsApi, | |
PerformanceAdvisorAPI: connV2.PerformanceAdvisorApi, | |
MongoDBCloudUsersAPI: connV2.MongoDBCloudUsersApi, | |
} | |
projectPropsParams := &APIClients{ | |
ProjectID: projectID, | |
IsDataSource: false, | |
ProjectsAPI: connV2.ProjectsApi, | |
TeamsAPI: connV2.TeamsApi, | |
PerformanceAdvisorAPI: connV2.PerformanceAdvisorApi, | |
MongoDBCloudUsersAPI: connV2.MongoDBCloudUsersApi, | |
} | |
And keep (ctx, projectPropsParams, &resp.Diagnostics) as the arguments?
…source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com>
…source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com>
* chore: Creates temporary workflow to create a test tag using Github actions (#3440) * chore: Use rebase instead of merge to update dev branches (#3442) * use rebase instead of merge to update dev branches * Update .github/workflows/update-dev-branches.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * improve doc --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Updates repository to use supported Terraform versions (#3450) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: JSON attributes in auto-generated resources (#3445) * stream_processor_api config * marshal JSON custom type * generate JSON custom type * formatGoFile * generated code * acc test * fix resouce.tmpl imports * revert changes to template * add import for custom types * wait * marshal tests * autogen tests * acc test with update of equivalent pipeline JSON * unmarshal test for custom type list * marshal error test * join acc tests * update generated code * fix marshal tests * fix delete config * same config as curated resource * chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) * use SP10 instead of default SP30 for stream_instance * fix linter * Revert "fix linter" This reverts commit 46270c0. * chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) * use JSON custom type * fix linter * chore: Updates Atlas Go SDK (#3446) * build(deps): bump go.mongodb.org/atlas-sdk * sdk changes --------- Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> * doc: Updates Terraform Compatibility Matrix documentation (#3449) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: Remove `links` attributes in auto-generated resources (#3455) * remove links attributes * move comment * chore: Fixes broken link because of ending parenthesis. (#3448) * chore: Fixes broken link because of ending parenthesis. * using link markdown syntax to avoid broken link --------- Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> * feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) * add send_user_provided_resource_tags * changelog * fmt * docs and example * test * refactor * rename files * new line * chore: Updates CHANGELOG.md for #3454 * chore: Singletons in auto-generated resources (#3458) * initial auditing_api and maintenance_window_api generation * fix unmarshal for empty JSON * improve maintenance_window_api * checkDestroy in manual resource tests * explicit version header * check apiResp is not nil * support FixedRequestBody * auditing except delete * support FixedRequestBody * comment in MakeApiError * comment Unmarshal * use same flow as in SDK * rename FixedRequestBody to StaticRequestBody * codegen tests * revert unneeded test * lowering timeout value to ensure creation fails consistently (#3462) * doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) * fixing inconsistent documentation * remove human-readable term in external_group_id attribute * fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) * chore: Add windsurf ignore * fix: Standardizes API params with WithParams pattern and IntPtr conversion * chore: Adds changelog file * refactor: use ListBackupExportJobsWithParams for export job listing * chore: Updates CHANGELOG.md for #3459 * feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com>
* feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> * chore: Update CLOUDP-320243-dev-2.0.0 from master (#3457) * chore: Creates temporary workflow to create a test tag using Github actions (#3440) * chore: Use rebase instead of merge to update dev branches (#3442) * use rebase instead of merge to update dev branches * Update .github/workflows/update-dev-branches.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * improve doc --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Updates repository to use supported Terraform versions (#3450) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: JSON attributes in auto-generated resources (#3445) * stream_processor_api config * marshal JSON custom type * generate JSON custom type * formatGoFile * generated code * acc test * fix resouce.tmpl imports * revert changes to template * add import for custom types * wait * marshal tests * autogen tests * acc test with update of equivalent pipeline JSON * unmarshal test for custom type list * marshal error test * join acc tests * update generated code * fix marshal tests * fix delete config * same config as curated resource * chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) * use SP10 instead of default SP30 for stream_instance * fix linter * Revert "fix linter" This reverts commit 46270c0. * chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) * use JSON custom type * fix linter * chore: Updates Atlas Go SDK (#3446) * build(deps): bump go.mongodb.org/atlas-sdk * sdk changes --------- Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> * doc: Updates Terraform Compatibility Matrix documentation (#3449) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: Remove `links` attributes in auto-generated resources (#3455) * remove links attributes * move comment * chore: Fixes broken link because of ending parenthesis. (#3448) * chore: Fixes broken link because of ending parenthesis. * using link markdown syntax to avoid broken link --------- Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> * feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) * add send_user_provided_resource_tags * changelog * fmt * docs and example * test * refactor * rename files * new line * chore: Updates CHANGELOG.md for #3454 * chore: Singletons in auto-generated resources (#3458) * initial auditing_api and maintenance_window_api generation * fix unmarshal for empty JSON * improve maintenance_window_api * checkDestroy in manual resource tests * explicit version header * check apiResp is not nil * support FixedRequestBody * auditing except delete * support FixedRequestBody * comment in MakeApiError * comment Unmarshal * use same flow as in SDK * rename FixedRequestBody to StaticRequestBody * codegen tests * revert unneeded test * lowering timeout value to ensure creation fails consistently (#3462) * doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) * fixing inconsistent documentation * remove human-readable term in external_group_id attribute * fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) * chore: Add windsurf ignore * fix: Standardizes API params with WithParams pattern and IntPtr conversion * chore: Adds changelog file * refactor: use ListBackupExportJobsWithParams for export job listing * chore: Updates CHANGELOG.md for #3459 * feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: svc-apix-Bot <142542575+svc-apix-Bot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com>
* feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> * Added `users` attribute, modified test and docs. * Updated doc * chore: Update CLOUDP-320243-dev-2.0.0 from master (#3457) * chore: Creates temporary workflow to create a test tag using Github actions (#3440) * chore: Use rebase instead of merge to update dev branches (#3442) * use rebase instead of merge to update dev branches * Update .github/workflows/update-dev-branches.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * improve doc --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Updates repository to use supported Terraform versions (#3450) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: JSON attributes in auto-generated resources (#3445) * stream_processor_api config * marshal JSON custom type * generate JSON custom type * formatGoFile * generated code * acc test * fix resouce.tmpl imports * revert changes to template * add import for custom types * wait * marshal tests * autogen tests * acc test with update of equivalent pipeline JSON * unmarshal test for custom type list * marshal error test * join acc tests * update generated code * fix marshal tests * fix delete config * same config as curated resource * chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) * use SP10 instead of default SP30 for stream_instance * fix linter * Revert "fix linter" This reverts commit 46270c0. * chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) * use JSON custom type * fix linter * chore: Updates Atlas Go SDK (#3446) * build(deps): bump go.mongodb.org/atlas-sdk * sdk changes --------- Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> * doc: Updates Terraform Compatibility Matrix documentation (#3449) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: Remove `links` attributes in auto-generated resources (#3455) * remove links attributes * move comment * chore: Fixes broken link because of ending parenthesis. (#3448) * chore: Fixes broken link because of ending parenthesis. * using link markdown syntax to avoid broken link --------- Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> * feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) * add send_user_provided_resource_tags * changelog * fmt * docs and example * test * refactor * rename files * new line * chore: Updates CHANGELOG.md for #3454 * chore: Singletons in auto-generated resources (#3458) * initial auditing_api and maintenance_window_api generation * fix unmarshal for empty JSON * improve maintenance_window_api * checkDestroy in manual resource tests * explicit version header * check apiResp is not nil * support FixedRequestBody * auditing except delete * support FixedRequestBody * comment in MakeApiError * comment Unmarshal * use same flow as in SDK * rename FixedRequestBody to StaticRequestBody * codegen tests * revert unneeded test * lowering timeout value to ensure creation fails consistently (#3462) * doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) * fixing inconsistent documentation * remove human-readable term in external_group_id attribute * fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) * chore: Add windsurf ignore * fix: Standardizes API params with WithParams pattern and IntPtr conversion * chore: Adds changelog file * refactor: use ListBackupExportJobsWithParams for export job listing * chore: Updates CHANGELOG.md for #3459 * feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> * Fixed test * Added changelog --------- Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: svc-apix-Bot <142542575+svc-apix-Bot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com>
…source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com>
…source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com>
* chore: Creates temporary workflow to create a test tag using Github actions (#3440) * chore: Use rebase instead of merge to update dev branches (#3442) * use rebase instead of merge to update dev branches * Update .github/workflows/update-dev-branches.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * improve doc --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Updates repository to use supported Terraform versions (#3450) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: JSON attributes in auto-generated resources (#3445) * stream_processor_api config * marshal JSON custom type * generate JSON custom type * formatGoFile * generated code * acc test * fix resouce.tmpl imports * revert changes to template * add import for custom types * wait * marshal tests * autogen tests * acc test with update of equivalent pipeline JSON * unmarshal test for custom type list * marshal error test * join acc tests * update generated code * fix marshal tests * fix delete config * same config as curated resource * chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) * use SP10 instead of default SP30 for stream_instance * fix linter * Revert "fix linter" This reverts commit 46270c0. * chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) * use JSON custom type * fix linter * chore: Updates Atlas Go SDK (#3446) * build(deps): bump go.mongodb.org/atlas-sdk * sdk changes --------- Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> * doc: Updates Terraform Compatibility Matrix documentation (#3449) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: Remove `links` attributes in auto-generated resources (#3455) * remove links attributes * move comment * chore: Fixes broken link because of ending parenthesis. (#3448) * chore: Fixes broken link because of ending parenthesis. * using link markdown syntax to avoid broken link --------- Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> * feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) * add send_user_provided_resource_tags * changelog * fmt * docs and example * test * refactor * rename files * new line * chore: Updates CHANGELOG.md for #3454 * chore: Singletons in auto-generated resources (#3458) * initial auditing_api and maintenance_window_api generation * fix unmarshal for empty JSON * improve maintenance_window_api * checkDestroy in manual resource tests * explicit version header * check apiResp is not nil * support FixedRequestBody * auditing except delete * support FixedRequestBody * comment in MakeApiError * comment Unmarshal * use same flow as in SDK * rename FixedRequestBody to StaticRequestBody * codegen tests * revert unneeded test * lowering timeout value to ensure creation fails consistently (#3462) * doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) * fixing inconsistent documentation * remove human-readable term in external_group_id attribute * fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) * chore: Add windsurf ignore * fix: Standardizes API params with WithParams pattern and IntPtr conversion * chore: Adds changelog file * refactor: use ListBackupExportJobsWithParams for export job listing * chore: Updates CHANGELOG.md for #3459 * feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com>
* chore: Creates temporary workflow to create a test tag using Github actions (#3440) * chore: Use rebase instead of merge to update dev branches (#3442) * use rebase instead of merge to update dev branches * Update .github/workflows/update-dev-branches.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * improve doc --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Updates repository to use supported Terraform versions (#3450) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: JSON attributes in auto-generated resources (#3445) * stream_processor_api config * marshal JSON custom type * generate JSON custom type * formatGoFile * generated code * acc test * fix resouce.tmpl imports * revert changes to template * add import for custom types * wait * marshal tests * autogen tests * acc test with update of equivalent pipeline JSON * unmarshal test for custom type list * marshal error test * join acc tests * update generated code * fix marshal tests * fix delete config * same config as curated resource * chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) * use SP10 instead of default SP30 for stream_instance * fix linter * Revert "fix linter" This reverts commit 46270c0. * chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) * use JSON custom type * fix linter * chore: Updates Atlas Go SDK (#3446) * build(deps): bump go.mongodb.org/atlas-sdk * sdk changes --------- Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> * doc: Updates Terraform Compatibility Matrix documentation (#3449) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: Remove `links` attributes in auto-generated resources (#3455) * remove links attributes * move comment * chore: Fixes broken link because of ending parenthesis. (#3448) * chore: Fixes broken link because of ending parenthesis. * using link markdown syntax to avoid broken link --------- Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> * feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) * add send_user_provided_resource_tags * changelog * fmt * docs and example * test * refactor * rename files * new line * chore: Updates CHANGELOG.md for #3454 * chore: Singletons in auto-generated resources (#3458) * initial auditing_api and maintenance_window_api generation * fix unmarshal for empty JSON * improve maintenance_window_api * checkDestroy in manual resource tests * explicit version header * check apiResp is not nil * support FixedRequestBody * auditing except delete * support FixedRequestBody * comment in MakeApiError * comment Unmarshal * use same flow as in SDK * rename FixedRequestBody to StaticRequestBody * codegen tests * revert unneeded test * lowering timeout value to ensure creation fails consistently (#3462) * doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) * fixing inconsistent documentation * remove human-readable term in external_group_id attribute * fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) * chore: Add windsurf ignore * fix: Standardizes API params with WithParams pattern and IntPtr conversion * chore: Adds changelog file * refactor: use ListBackupExportJobsWithParams for export job listing * chore: Updates CHANGELOG.md for #3459 * chore: Docs team review improvements in dev branches (#3466) * TEMPORARY send to test channel * don't notify docs team if label skip-docs-notification * TEMPORARY doc change * add label skip label in update dev branches GHA * Revert "TEMPORARY doc change" This reverts commit de69883. * Revert "TEMPORARY send to test channel" This reverts commit c7e2746. * detect changes * don't create the PR is no new changes * fix linter * add step names * feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> * chore: Update CLOUDP-320243-dev-2.0.0 from master (#3457) * chore: Creates temporary workflow to create a test tag using Github actions (#3440) * chore: Use rebase instead of merge to update dev branches (#3442) * use rebase instead of merge to update dev branches * Update .github/workflows/update-dev-branches.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * improve doc --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Updates repository to use supported Terraform versions (#3450) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: JSON attributes in auto-generated resources (#3445) * stream_processor_api config * marshal JSON custom type * generate JSON custom type * formatGoFile * generated code * acc test * fix resouce.tmpl imports * revert changes to template * add import for custom types * wait * marshal tests * autogen tests * acc test with update of equivalent pipeline JSON * unmarshal test for custom type list * marshal error test * join acc tests * update generated code * fix marshal tests * fix delete config * same config as curated resource * chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) * use SP10 instead of default SP30 for stream_instance * fix linter * Revert "fix linter" This reverts commit 46270c0. * chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) * use JSON custom type * fix linter * chore: Updates Atlas Go SDK (#3446) * build(deps): bump go.mongodb.org/atlas-sdk * sdk changes --------- Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> * doc: Updates Terraform Compatibility Matrix documentation (#3449) Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> * chore: Remove `links` attributes in auto-generated resources (#3455) * remove links attributes * move comment * chore: Fixes broken link because of ending parenthesis. (#3448) * chore: Fixes broken link because of ending parenthesis. * using link markdown syntax to avoid broken link --------- Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> * feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454) * add send_user_provided_resource_tags * changelog * fmt * docs and example * test * refactor * rename files * new line * chore: Updates CHANGELOG.md for #3454 * chore: Singletons in auto-generated resources (#3458) * initial auditing_api and maintenance_window_api generation * fix unmarshal for empty JSON * improve maintenance_window_api * checkDestroy in manual resource tests * explicit version header * check apiResp is not nil * support FixedRequestBody * auditing except delete * support FixedRequestBody * comment in MakeApiError * comment Unmarshal * use same flow as in SDK * rename FixedRequestBody to StaticRequestBody * codegen tests * revert unneeded test * lowering timeout value to ensure creation fails consistently (#3462) * doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460) * fixing inconsistent documentation * remove human-readable term in external_group_id attribute * fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459) * chore: Add windsurf ignore * fix: Standardizes API params with WithParams pattern and IntPtr conversion * chore: Adds changelog file * refactor: use ListBackupExportJobsWithParams for export job listing * chore: Updates CHANGELOG.md for #3459 * feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439) * WIP * Fixed acceptance test * Added a comment * Added changelog * Update docs/data-sources/project.md * Update .changelog/3439.txt Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * PR comments * Fix * Arguments fixed * Fix constant --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * feat: Adds users attribute to mongodbatlas_projects plural data source (#3451) * WIP * Fixed acceptance test * Added a comment * Added changelog * Added users attribute to projects data source * Added changelog and fixed docs * Factored out users schema * Refactored schemas and fixed test and doc * Minor code review suggestions and fixed doc --------- Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com> --------- Co-authored-by: maastha <122359335+maastha@users.noreply.github.com> Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: oarbusi <55513886+oarbusi@users.noreply.github.com> Co-authored-by: Oriol Arbusi Abadal <oriol.abadal@mongodb.com> Co-authored-by: Marco Suma <marco.suma@mongodb.com> Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: Cristina Sánchez <c.sanchezprincipal@gmail.com> Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com>
Description
Adds
users
attribute tomongodbatlas_project
singular data source.Link to any related issue(s):
CLOUDP-324845
Type of change:
Required Checklist:
Further comments