Skip to content

add test for the implicit corotine decoration of XMLRPC methods #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add test for the implicit corotine decoration of XMLRPC methods #33

wants to merge 1 commit into from

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Jan 29, 2020 •
edited
Loading

this is #31 without the controversial replacement for asyncio.coroutine

@graingert
Copy link
Contributor Author

graingert commented Jan 29, 2020 •
edited
Loading

I hope to make a PR to remove this behaviour (for a future v1 release?) and require that all rpc_ methods return awaitables

@graingert graingert requested a review from mosquito January 29, 2020 14:52
@mosquito
Copy link
Owner

Please rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosquito mosquito Awaiting requested review from mosquito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graingert @mosquito