Skip to content

Conversation

eviljeff
Copy link
Member

@eviljeff eviljeff commented Jul 18, 2025

Fixes mozilla/addons#15631 and fixes mozilla/addons#15627

Moves Recommendations (aka Other popular extensions) and Permissions cards to their eventual final position in the new detail page layout.

Also adjusts the number of columns to match figma (2 at large, 3 at extraLarge) - and repeats that style adjustment for the extensions by author card for consistency (author card is not shown on the figma, so it remains at it's old position, at the bottom of the page)

medium/500px

Screen Shot 2025-07-18 at 17 26 03-fullpage

large/720px

Screen Shot 2025-07-18 at 17 25 57-fullpage

extraLarge

Screen Shot 2025-07-18 at 17 25 49-fullpage

extraExtraLarge

Screen Shot 2025-07-18 at 17 25 36-fullpage

@eviljeff eviljeff requested review from willdurand and KevinMind July 18, 2025 17:42
@KevinMind
Copy link
Contributor

KevinMind commented Jul 21, 2025

General purpose nit for the screenshots in the description:

  • use ## headers so you get the description and a line break to easily know when one screenshot ends and another starts
  • specify an absolute width value on the html tag and set height to auto, otherwise it distorts the image and makes it too big.
  • make the screenshots focus on the main part of the screen you want to represent, I have to do a ton of scrolling to see the relevant part and I almost get lost or forget what I'm comparing by the time I find the same section in the next screenshot.

Felt appropriate to add this to the PR template if you agree?

@eviljeff
Copy link
Member Author

General purpose nit for the screenshots in the description:

* use ## headers so you get the description and a line break to easily know when one screenshot ends and another starts

On my machine I already had line breaks? I.e. the text and images were always on different lines, so it was clear where one screenshot ended and another starts. Headings are nicer, I won't disagree, but not essential.

* specify an absolute `width` value on the html tag and set height to auto, otherwise it distorts the image and makes it too big.

yes it's weird that github doesn't do this

* make the screenshots focus on the main part of the screen you want to represent, I have to do a ton of scrolling to see the relevant part and I almost get lost or forget what I'm comparing by the time I find the same section in the next screenshot.

I would do that - and have done for previous prs you've reviewed - but in this case the fix in the pr is the layout, so I had to include the whole screen to demonstrate the layout (and I manually cropped off the footers).

Felt appropriate to add this to the PR template if you agree?

I don't think screenshot instructions are a priority, compared to the project this issue is a part of.

Copy link
Contributor

@KevinMind KevinMind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

@eviljeff eviljeff merged commit 9b28525 into master Jul 24, 2025
11 checks passed
@eviljeff eviljeff deleted the 15631-move-recommendations-and-permissions-cards branch July 24, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Move and adjust OtherPopularExtensionsCard [Task]: Move and adjust PrivacyPermissionsCard
2 participants