feat(nimbus): add results to new nimbus ui #12732
Conversation
jaredlockhart
requested review from
yashikakhurana and
freshstrangemusic
as code owners
|
Followup: #12734 |
There was a problem hiding this comment.
@jaredlockhart I tried running it locally, it build correctly and loads results correctly, but something is off with the styling, when I click on the results page all timeline and sidebar moves
| RESULTS_SCHEMA_CHECK = python manage.py graphql_schema --out experimenter/results/test_schema.graphql&&diff experimenter/results/test_schema.graphql experimenter/results/schema.graphql || (echo GraphQL Schema is out of sync please run make generate_types;exit 1) | ||
| NIMBUS_TYPES_GENERATE = python manage.py graphql_schema --out experimenter/nimbus-ui/schema.graphql&&yarn workspace @experimenter/nimbus-ui generate-types | ||
| RESULTS_TYPES_GENERATE = python manage.py graphql_schema --out experimenter/results/schema.graphql&&yarn workspace @experimenter/results generate-types |
There was a problem hiding this comment.
we should add this in make check command
There was a problem hiding this comment.
can we add RESULTS_TYPE_GENERATE AND RESULTS_SCHEMA_CHECK as part of make check command
| {% block main_content %} | ||
| <div id="root" data-config="{{ APP_CONFIG }}"></div> | ||
| {% endblock main_content %} | ||
|
|
||
| {% block extrascripts %} | ||
| {% if USE_YARN_DEV %} |
|
Aha! I discovered that the Results JS package was loading boostrap4.5 which was conflicting with bootstrap 5 that nimbus ui new uses. So I removed the boostrap4.5 import, and updated the rules and styles, so that fixes the layout problem, and also unlocks dark mode! |
| RESULTS_SCHEMA_CHECK = python manage.py graphql_schema --out experimenter/results/test_schema.graphql&&diff experimenter/results/test_schema.graphql experimenter/results/schema.graphql || (echo GraphQL Schema is out of sync please run make generate_types;exit 1) | ||
| NIMBUS_TYPES_GENERATE = python manage.py graphql_schema --out experimenter/nimbus-ui/schema.graphql&&yarn workspace @experimenter/nimbus-ui generate-types | ||
| RESULTS_TYPES_GENERATE = python manage.py graphql_schema --out experimenter/results/schema.graphql&&yarn workspace @experimenter/results generate-types |
There was a problem hiding this comment.
can we add RESULTS_TYPE_GENERATE AND RESULTS_SCHEMA_CHECK as part of make check command
| export const GET_EXPERIMENTS_QUERY = gql` | ||
| query getAllExperiments { | ||
| experiments { | ||
| isArchived | ||
| isRollout | ||
| name | ||
| owner { | ||
| username | ||
| } | ||
| featureConfigs { | ||
| id | ||
| slug | ||
| name | ||
| description | ||
| application | ||
| ownerEmail | ||
| } | ||
| targetingConfig { | ||
| label | ||
| value | ||
| description | ||
| applicationValues | ||
| stickyRequired | ||
| isFirstRunRequired | ||
| } | ||
| slug | ||
| application | ||
| firefoxMinVersion | ||
| firefoxMaxVersion | ||
| startDate | ||
| isRolloutDirty | ||
| isEnrollmentPausePending | ||
| proposedDuration | ||
| proposedEnrollment |
There was a problem hiding this comment.
calling this all, means we still have to keep our graphql intact 🤔
There was a problem hiding this comment.
can we just only call those params that we need
There was a problem hiding this comment.
Oh I'm definitely not going to start digging into the details of the GraphQL for this ticket, I just want to get this page landed.
Yes we have to keep the GQL alive as long as the results page is in its current state. When we make a new one we can remove it entirely.
Because * We need to add a results page to the new Nimbus UI * We can use the existing results page until we have a more suitable replacement This commit * Makes a copy of the nimbus-ui React app called results * Removes all components except those necessary for the results page * Adds all of the Makefile entry points to test, lint, etc the new results app * Adds all of the build/copy steps for the new results app to the Dockerfile * Adds a new url/view for the results page in nimbus_ui_new fixes #12707
Because
This commit
fixes #12707
