Skip to content

chore(cirrus): include fml files in docker image #12843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(cirrus): include fml files in docker image #12843

wants to merge 1 commit into from

Conversation

relud
Copy link
Contributor

@relud relud commented Jun 24, 2025 •
edited
Loading

Because

  • cirrus web needs access to fml files, and this is easier than mounting the files in the helm chart and needing to synchronize them across separate repos

This commit

  • adds --no-deps to the docker compose command to fetch fml updates
  • adds the experimenter feature manifests directory to /fml in the cirrus image
  • adds initial fml for experimenter

fixes EXP-5553 along with https://github.com/mozilla/webservices-infra/pull/6211

@relud relud force-pushed the relud-cirrus-fml branch 2 times, most recently from facd90e to fef9662 Compare June 24, 2025 19:21
jeddai
jeddai reviewed Jun 24, 2025
View reviewed changes
Copy link
Member

@jeddai jeddai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to define the base FML yaml and then have build steps that generate the individual environment yamls

@relud relud marked this pull request as draft June 24, 2025 20:12
@relud relud force-pushed the relud-cirrus-fml branch 4 times, most recently from 625626a to 63655f2 Compare June 24, 2025 20:53
@relud relud force-pushed the relud-cirrus-fml branch from 63655f2 to d10ebc8 Compare June 24, 2025 20:54
@relud relud marked this pull request as ready for review June 24, 2025 20:55
@relud relud requested a review from jeddai June 24, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart is a code owner

@yashikakhurana yashikakhurana Awaiting requested review from yashikakhurana yashikakhurana is a code owner

@freshstrangemusic freshstrangemusic Awaiting requested review from freshstrangemusic freshstrangemusic is a code owner

@jeddai jeddai Awaiting requested review from jeddai jeddai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@relud @jeddai