fix(tests): Update filter expression script to use ExperimentAPI module.

[b4handjr]

Because

• Our targeting tests are failing due to a change in an upstream module we consume to creating targeting contexts.

This commit

• Updates our script to use the newer ExperimenterAPI module.

Fixes #12851

[freshstrangemusic]

This returns a promise

Suggested change

	ExperimentAPI.ready();
	await ExperimentAPI.ready();

[freshstrangemusic]

There is a typo in the PR title: ExperimetAPI

[freshstrangemusic]

Instead of taking the callback as an arg, lets do remoteSettings(targetingString, recipe).then(callback, () => null)

It makes the control flow of remoteSettings cleaner and it doesnt need a bunch of try/catch.

[freshstrangemusic]

if we dont take callback as an arg, we can just return immediately here. We dont even need to try/catch

[freshstrangemusic]

and here.

[freshstrangemusic]

I do not understand how this is supposed to work

[b4handjr]

We use it in the test

with filter_expression_path.open() as js:
        result = Browser.execute_async_script(
            selenium,
            targeting,
            json.dumps({"experiment": recipe}),
            script=js.read(),
            context="chrome",
        )

[freshstrangemusic]

In the example you gave, context="chrome" so we're in the other branch. From inspection, you would have to use this like:

result = Browser.execute_async_script()(script)

[freshstrangemusic]

In the example you gave, context="chrome" so we're in the other branch. From inspection, you would have to use this like:

result = Browser.execute_async_script()(script)

[freshstrangemusic]

This should be

return self.execute_async_script(script, *args)

see my other comment.