Ability to parse JWT UserInfo payload #549
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmm, e2e testing is failing, but it does not seem to be code related : |
qbey
reviewed
Apr 23, 2025
mozilla_django_oidc/auth.py
Outdated
| @@ -279,6 +279,12 @@ def get_userinfo(self, access_token, id_token, payload): | |||
| proxies=self.get_settings("OIDC_PROXY", None), | |||
| ) | |||
| user_response.raise_for_status() | |||
|
|
|||
| if user_response.headers.get("content-type", "").startswith("application/jwt"): | |||
There was a problem hiding this comment.
MIME types are case-insensitive you may want to be also?
MIME types are case-insensitive but are traditionally written in lowercase. The parameter values can be case-sensitive.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/MIME_types
Suggested change
| if user_response.headers.get("content-type", "").startswith("application/jwt"): | |
| if user_response.headers.get("content-type", "").lower().startswith("application/jwt"): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible fix for #548 + simple content-type test