Allow backup with a pure wireless setup. #149
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a pure wireless setup, then it's impossible to connect to the phone and get it's IP address and port configuration until the debugging connection has been set up. Also, every time a new connection is made, the user has to do manual work to read the security code from the phone and give it to the pairing command. In this situation, I think it makes more sense to have the user set up a static connection and to leave that connection in place all the time.
This patch reorganizes the startup so that the wireless vs USB question happens as soon as possible and then disables killing and restarting the adb server if wireless is to be used.
I have not tested this with the old (pre Android 11) wireless setup and I think that the patch breaks that. Android 11 is already EOL, so my feeling is that support for it should be removed with a documentation pointer to the last version of
open-android-backup
that it would work with. If I get some feedback about this I may update the patch, either to make the old version work as it used to or to or to delete the old code.