mTCP support for SPDK #287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rte_eth_dev_count is deprecated and use rte_eth_dev_count_avail instead. Signed-off-by: Qingmin Liu <qingmin.liu@broadcom.com>
- Use variable CROSS to specify toolchain prefix - Use variable RTE_KERNELDIR to specify kernel build dir if RTE_KERNELDIR is not defined. Signed-off-by: Qingmin Liu <qingmin.liu@broadcom.com>
- If ARCH is not defined, retrieve it from system. - Only x86_64 adds -m64 Signed-off-by: Qingmin Liu <qingmin.liu@broadcom.com>
- If not it cannot find external lib Signed-off-by: Qingmin Liu <qingmin.liu@broadcom.com>
- Verified at ARM64 Platform. - For dependencies, introduce ext_lib to specify the dir. Signed-off-by: Qingmin Liu <qingmin.liu@broadcom.com>
APP has already done initialization. However mtcp will call it again and report error. It should be avoided otherwise APP will also exit unexpectly.
1. Add --enable-spdk suppport. 2. Pass ENABLE_SPDK based on cfg.
Stingray has only 320-bit RSS key. So limit to 40B at the max.
…s compile Specify ARCH/CROSS_COMPILE when build kernel module.
1. mtcp_destroy strict prototype 2. mtcp_read no inline
SPDK poller will register seperately with mtcp_run_instance. Modify MTCPRunThread for SPDK scenario.
Introduce '-e' option to enable spdk. - Disable spdk support without '-e'. - Enable spdk support with '-e'.
Add README.spdk for mtcp+spdk integration. Signed-off-by: Qingmin Liu <calmarrow@gmail.com>
- dpdk 19.11 added rte_ to some variables and struct. - change it to support this.
qingmin-liu
force-pushed
the
spdk_mtcp_dev
branch
from
8d725bf to
1dd9131
Compare
|
Hi, does that mean that you plan to upstream mTCP in SPDK? |
Author
|
In fact I want but brcm may have another upstream policy and will review internally. |
Don't do that :D to me, mTCP seems like a toy project. See #306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mTCP support for SPDK.
For spdk changes, we are preparing for upstream and when it's ready, will introduce submodule for spdk and give test case steps of nvmeotcp.
Thanks a lot.
Qingmin