feat(iroh)!: allow dynamic changing of the RelayMap of an endpoint
#3522
+232
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3522/docs/iroh/ Last updated: 2025-10-14T15:21:39Z |
flub
reviewed
Oct 9, 2025
| self.nodes.keys() | ||
| pub fn urls<T>(&self) -> T | ||
| where | ||
| T: FromIterator<RelayUrl>, |
There was a problem hiding this comment.
that's... fancy
And maybe a little unfortunate as we're now forcing an allocation. But I guess this is needed because the the inner lock.
| } | ||
|
|
||
| fn handle_relay_map_change(&mut self) { | ||
| self.re_stun(UpdateReason::RelayMapChange); |
There was a problem hiding this comment.
this is like the only thing that is needed, and the test just works? I'm both impressed and surprised!
dignifiedquire
force-pushed
the
feat-dynamic-relay-map
branch
2 times, most recently
from
6aa6834 to
1dd5391
Compare
dignifiedquire
force-pushed
the
feat-dynamic-relay-map
branch
from
1dd5391 to
7691912
Compare
dignifiedquire
force-pushed
the
feat-dynamic-relay-map
branch
from
7691912 to
8e45460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3471
Breaking Changes
iroh::Endpoint::insert_relayiroh::Endpoint::remove_relayiroh::Endpoint::RelayMap::insertiroh::Endpoint::RelayMap::removeiroh_relay::RelayMap::urlsiroh_relay::RelayMap::nodesiroh_relay::RelayMap::get_nodeNotes & open questions
RelayMapacceptable?