refactor(iroh)!: finish removal of add_node_addr from public api

[Frando]

Description

• Removes Endpoint::add_node_addr_with_source
• Changes visibility of Endpoint::add_node_addr from private to pub(crate) and add a source argument, and uses it in discovery instead of the now-removed add_node_addr_with_source
• Refactors a few tests to not use Endpoint::add_node_addr anymore

The only remaining uses of Endpoint::add_node_addr are now in Endpoint::connect (when passing a NodeAddr) and in the task processing discovery results. Yay!

Breaking Changes

• iroh::Endpoint::add_node_addr_with_source is removed. Use a discovery service instead.

Notes & open questions

Change checklist

• Self-review.
• Documentation updates following the style guide, if relevant.
• Tests if relevant.
• All breaking changes documented.
  • List all breaking changes in the above "Breaking Changes" section.
  • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:
    • quic-rpc
    • iroh-gossip
    • iroh-blobs
    • dumbpipe
    • sendme

[github-actions]

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3528/docs/iroh/

Last updated: 2025-10-14T10:22:20Z

[github-actions]

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 3117bde