Skip to content

Conversation

@nabla-c0d3
Copy link
Owner

No description provided.

jagu-sayan and others added 2 commits March 5, 2025 12:08
Context:
* no way to use custom profile for compliance checks
feat: add cli option to use custom tls config
@nabla-c0d3 nabla-c0d3 requested a review from Copilot August 3, 2025 14:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR finalizes the "custom TLS profile" functionality by refactoring Mozilla TLS profile checking to support custom TLS configurations. The implementation moves from a Mozilla-specific checker to a generic TLS configuration system that can validate against both Mozilla profiles and user-defined configurations.

Key Changes:

  • Refactored TLS configuration checking from Mozilla-specific to generic approach
  • Added support for custom TLS configuration files via --custom_tls_config CLI option
  • Renamed classes and enums to reflect the broader TLS configuration scope
  • Updated test files to use the new API and added test coverage for custom configurations

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_mozilla_tls_profile/test_mozilla_tls_config.py Updated test imports and method calls to use new generic TLS config API
tests/test_mozilla_tls_profile/test_custom_tls_config.py New test file for custom TLS configuration functionality
tests/test_main.py Added tests for command line parsing with custom TLS config files
tests/factories.py Updated factory to use new TLS config field names
sslyze/mozilla_tls_profile/tls_config_checker.py Major refactoring - renamed classes, made TlsConfigurationAsJson public, changed function signatures
sslyze/cli/command_line_parser.py Added custom TLS config CLI option and parsing logic
sslyze/__main__.py Updated main function to use new TLS config checking API
custom_tls_config_example.json New example custom TLS configuration file
README.md Updated documentation to describe custom TLS config functionality
Comments suppressed due to low confidence (1)

tests/test_mozilla_tls_profile/test_custom_tls_config.py:11

  • The method name contains 'lol' which is unprofessional and unclear. Consider renaming to 'test_custom_config_compliance_checking_noncompliant_server' or similar.
    def test_custom_config_compliance_checking_noncompliant_server_lol(self):

@nabla-c0d3 nabla-c0d3 force-pushed the #686-custom-tls-profile branch from 7c6a216 to 0dab2ce Compare August 3, 2025 14:12
@nabla-c0d3 nabla-c0d3 merged commit c54a7f0 into dev Aug 3, 2025
0 of 6 checks passed
@nabla-c0d3 nabla-c0d3 deleted the #686-custom-tls-profile branch August 3, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants