Skip to content

Ignore incidental OpenSSLError in cert scan, ref #690 #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release
Choose a base branch
from
Open

Ignore incidental OpenSSLError in cert scan, ref #690 #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sslyze/plugins/certificate_info/implementation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def result_for_completed_scan_jobs(
received_chain_as_pem, ocsp_response, custom_ca_file, was_sni_used = completed_job.get_result()
assert received_chain_as_pem, "Should never happen as we always retrieve a certificate chain"

except TlsHandshakeFailed as exc:
except (TlsHandshakeFailed, nassl._nassl.OpenSSLError) as exc:
# Can happen when trying to connect with specific cipher suites (such as RSA or non-RSA)
# or when connectivity is bad
all_handshake_failed_exceptions.append(exc)
Expand Down
Loading