Skip to content

Fix docs deployment with gallery env variable #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2022
Merged

Fix docs deployment with gallery env variable #70

merged 1 commit into from
Dec 14, 2022

Conversation

melissawm
Copy link
Member

Description

Follow up to #5 . Fixes the docs deployment action to take into account the new GALLERY_PATH environment variable in the makefile.

Type of change

  • Fixes or improves existing content
  • Adds new content page(s)
  • Fixes or improves workflow, documentation build or deployment

References

#5

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have added alt text to new images included in this PR

@github-actions github-actions bot added the task label Dec 12, 2022
@melissawm melissawm requested a review from jni December 12, 2022 23:28
@psobolewskiPhD psobolewskiPhD mentioned this pull request Dec 14, 2022
Closed
@psobolewskiPhD psobolewskiPhD requested a review from Czaki December 14, 2022 21:22
@aganders3 aganders3 mentioned this pull request Dec 14, 2022
Merged
2 tasks
@Czaki Czaki merged commit 1ab9b59 into napari:main Dec 14, 2022
@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Oct 24, 2023
@melissawm melissawm deleted the update-deploy-docs branch January 9, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brisvag brisvag brisvag approved these changes

@jni jni Awaiting requested review from jni

@Czaki Czaki Awaiting requested review from Czaki

Assignees

@melissawm melissawm

Labels
task
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@melissawm @brisvag @Czaki @psobolewskiPhD