-
Notifications
You must be signed in to change notification settings - Fork 12
Use default font for headings and body text #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR uses the default pydata sphinx theme font for body text and leaves barlow for heading
@DragaDoncila @psobolewskiPhD @melissawm For your review. |
Hmm CI is not happy 🥹 |
Blah, these unrelated to the PR seg faults concern me. @DragaDoncila can you restart the CI (I don't have sufficient permissions) to see if this is an intermittent seg fault or reproducible seg fault. |
As an aside, I don't think it is necessary to run a complete build of the docs for every theme change. I think for most cases a representative set of pages would suffice. |
@willingc re-ran! |
CI here needs to be updated for the changes in napari/docs and napari/napari.
Really good point. I put together the full build when we were first testing things with the theme and a new version of the upstream theme. But now that we arn't tinkering much, we could safely drop stuff -- like the gallery. |
Seg faulted again but in a different place. I think that we still need to work through the seg faults but I don't think this is the repo to do that. I would prefer napari/napari to be the place to do so or possibly napari/docs as well. If it is ok with you, I can put up a PR in the morning to swap the workflow to building the example docs. |
could also be the tensorstore constraints issue Grzegorz mentioned. lets see if my new PR passes. |
@DragaDoncila @willingc The build passes when updated for the latest changes to the docs dependencies (just like napari/docs and napari/napari): |
I optimistically merged #186 and will merge into here to see if that works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green now yay 🎉 and I've had a scroll through different pages like the API ref, pages with lots of code and text pages, and this all looks good to me. Thanks @willingc ❤️
@psobolewskiPhD why 0.7 milestone? |
@TimMonko we will need a release of this theme in order for it to be used by napari/docs. |
@psobolewskiPhD A release of this theme shouldn't be difficult. Looking at the code in napari/napari, there are only 2 places where the config/constraints list |
I didn't mean to imply it was difficult, but a release of the theme and then a PR to update of constraints does need to be done to see the effect of any PRs to the theme. |
I think me (and maybe @willingc ) assumed the 0.7 was tagged to the napari release milestone, but I've realized this is probably the sphinx theme milestone. Didn't realize the theme was a confusingly-close-to-napari 0.6.0 |
Oh, sorry! My b! |
Thanks @psobolewskiPhD. Yep, I totally thought we were discussing the napari release. All good. TYVM, @TimMonko Thanks for clarifying too. |
This PR uses the default pydata sphinx theme font for body text and headings.
and leaves barlow for heading.Addresses #88.
2025-02-27 docs workgroup meeting agreed that removing Barlow made sense. If needed, we can revisit the fonts in a future issue/PR.