enh: Introduce narwhals.sql
#3254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Oct 31, 2025
narwhals/sql.py
Outdated
| CREATE TABLE "{name}" | ||
| ({dtypes}); | ||
| """) | ||
| return from_native(CONN.table(name)) |
Member
Author
There was a problem hiding this comment.
🤔 maybe this could return a subclass of LazyFrame which has a to_sql method, with an optional dependency on sqlglot if people want to pass dialect != 'duckdb' or pretty=True
MarcoGorelli
commented
Nov 1, 2025
Comment on lines
+14
to
+26
| try: | ||
| import duckdb # ignore-banned-import | ||
| except ImportError as _exc: # pragma: no cover | ||
| msg = ( | ||
| "`narwhals.sql` requires DuckDB to be installed.\n\n" | ||
| "Hint: run `pip install -U narwhals[sql]`" | ||
| ) | ||
| raise ModuleNotFoundError(msg) from _exc | ||
|
|
||
| CONN = duckdb.connect() | ||
| TZ = DeferredTimeZone( | ||
| CONN.sql("select value from duckdb_settings() where name = 'TimeZone'") | ||
| ) |
Member
Author
There was a problem hiding this comment.
I think (hope?) that in the future we could make a narwhals-sqlglot or narwhals-substrait plugin and use that here. But for now, I think using DuckDB for this is quite nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below