-
Notifications
You must be signed in to change notification settings - Fork 172
feat: Add Expr.replace_strict support for lazy backends if default is provided
#3282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI failures are interesting:
|
|
Alright, I reported the issue to SQLFrame and added the relevant link and comments in the code. Yesterday I learned that reporting spark issue is just not that simple, so I settled on xfailing for pyspark connect. Regarding code sharing, I tried to abstract away a few parts but I didn't like the amount of inputs required to make it work, so I am marking this ready for review as is for now |
MarcoGorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @FBruzzesi !
I just simplified it slightly at the compliant level, as there were some unnecessary checks
What type of PR is this? (check all applicable)
Related issues
defaultin{Expr,Series}.replace_strictΒ #3276 (comment) and feat: Adddefaultin{Expr,Series}.replace_strictΒ #3276 (comment)Checklist
If you have comments or can explain your changes, please do so below
Very first iteration, mostly a proof of concept to make sure there is a brute forced way for each backend.
I am not targeting main, rather #3276, so that I already have: