Skip to content

Conversation

@liamholmes31
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
    • seemed not applicable for this one, but let me know if I'm missing something!
  • Documented the changes

If you have comments or can explain your changes, please do so below

Note, in the first commit I attempted the proposal from the issue discussion but ran into issues as it clashed with DAR103. The second commit worked around this lint rule, and still seems to achieve the desired functionality - but let me know if you have further thoughts!

@liamholmes31 liamholmes31 changed the title Chore/document closed interval options chore: document closed interval options Nov 7, 2025
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @liamholmes31 !

@MarcoGorelli MarcoGorelli merged commit 4e7df0e into narwhals-dev:main Nov 10, 2025
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: is_between doesn't show ClosedInterval values. Remove type aliases

2 participants