Skip to content

Update to godot 4.5! #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update to godot 4.5! #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf8f2b5
Update to godot 4.5
Fireye04 Sep 17, 2025
b76edb6
Revert "Fix custom test scene failing to run from UID (#885)"
Fireye04 Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dialogue Manager.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Godot.NET.Sdk/4.4.1">
<Project Sdk="Godot.NET.Sdk/4.5.0">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<EnableDynamicLoading>true</EnableDynamicLoading>
Expand Down
25 changes: 11 additions & 14 deletions addons/dialogue_manager/views/main_view.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,16 +836,6 @@ func show_search_form(is_enabled: bool) -> void:
search_and_replace.focus_line_edit()


func run_test_scene(from_key: String) -> void:
DMSettings.set_user_value("run_title", from_key)
DMSettings.set_user_value("is_running_test_scene", true)
DMSettings.set_user_value("run_resource_path", current_file_path)
var test_scene_path: String = DMSettings.get_setting(DMSettings.CUSTOM_TEST_SCENE_PATH, "res://addons/dialogue_manager/test_scene.tscn")
if ResourceUID.has_id(ResourceUID.text_to_id(test_scene_path)):
test_scene_path = ResourceUID.get_id_path(ResourceUID.text_to_id(test_scene_path))
EditorInterface.play_custom_scene(test_scene_path)


### Signals


Expand Down Expand Up @@ -1082,7 +1072,11 @@ func _on_test_button_pressed() -> void:
errors_dialog.popup_centered()
return

run_test_scene("")
DMSettings.set_user_value("run_title", "")
DMSettings.set_user_value("is_running_test_scene", true)
DMSettings.set_user_value("run_resource_path", current_file_path)
var test_scene_path: String = DMSettings.get_setting(DMSettings.CUSTOM_TEST_SCENE_PATH, "res://addons/dialogue_manager/test_scene.tscn")
EditorInterface.play_custom_scene(test_scene_path)


func _on_test_line_button_pressed() -> void:
Expand All @@ -1097,9 +1091,12 @@ func _on_test_line_button_pressed() -> void:
for i in range(code_edit.get_cursor().y, code_edit.get_line_count()):
if not code_edit.get_line(i).is_empty():
line_to_run = i
break

run_test_scene(str(line_to_run))
break;
DMSettings.set_user_value("run_title", str(line_to_run))
DMSettings.set_user_value("is_running_test_scene", true)
DMSettings.set_user_value("run_resource_path", current_file_path)
var test_scene_path: String = DMSettings.get_setting(DMSettings.CUSTOM_TEST_SCENE_PATH, "res://addons/dialogue_manager/test_scene.tscn")
EditorInterface.play_custom_scene(test_scene_path)


func _on_support_button_pressed() -> void:
Expand Down
2 changes: 1 addition & 1 deletion project.godot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ config_version=5
config/name="Dialogue Manager"
config/tags=PackedStringArray("addon")
run/main_scene="res://tests/tests.tscn"
config/features=PackedStringArray("4.4", "C#")
config/features=PackedStringArray("4.5", "C#")
config/icon="res://icon.svg"

[autoload]
Expand Down