Skip to content

Fix GetValidators error handling #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix GetValidators error handling #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/lua_oasvalidator_imp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,27 +56,38 @@ int lua_GetValidators(lua_State* L)
const char* oas_specs = luaL_checkstring(L, 1);
std::unordered_map<std::string, std::unordered_set<std::string>> method_map = {};
if (num_args == 2) {
luaL_checktype(L, 2, LUA_TTABLE);
LuaTableToUnorderedMapSet(L, 2, method_map);
}
auto* oas_validators_imp = new OASValidatorImp(oas_specs, method_map);
if (oas_validators_imp) {
OASValidatorImp** ud = reinterpret_cast<OASValidatorImp**>(lua_newuserdata(L, sizeof(*ud)));
if (!ud) {
delete oas_validators_imp;
luaL_error(L, "Out of memory");
lua_pushnil(L);
lua_pushliteral(L, "Out of memory");
return 2;
}
*ud = oas_validators_imp;
luaL_getmetatable(L, METATABLE_NAME);
lua_setmetatable(L, -2);
lua_pushnil(L);
return 2;

} else {
lua_pushnil(L);
lua_pushliteral(L, "Failed to create validators");
return 2;
}
} catch (const ValidatorInitExc& ex) {
lua_pushnil(L);
luaL_error(L, ex.what());
lua_pushstring(L, ex.what());
return 2;
} catch (const std::exception& ex) {
lua_pushnil(L);
lua_pushstring(L, ex.what());
return 2;
}
return 1;
}

int metamethod_gc(lua_State* L)
Expand Down
Loading