Skip to content

[5.28] Flesh out Driver.Close docs #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 5.0
Choose a base branch
from

Conversation

robsdedude
Copy link
Member

@robsdedude robsdedude commented Aug 8, 2025

  • Copy over concurrency warning to DriverWithContext.Close.
  • Add to both Close docs recommendation to finish using driver resources before closing the driver for a more predictable behavior.

Backport of #650

 * Copy over concurrency warning to `DriverWithContext.Close`.
 * Add to both Close docs recommendation to finish using driver resources before
   closing the driver for a more predictable behavior.
@robsdedude robsdedude changed the title Flesh out Driver.Close docs [5.28] Flesh out Driver.Close docs Aug 8, 2025
@robsdedude robsdedude marked this pull request as ready for review August 8, 2025 09:10
Copy link

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear explanation. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants