Add "airflow" and "profile" to moduletype test #3364
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for two new properties in the moduletype JSON schema: "airflow" and "profile" to align with NetBox functionality and enable better module type definitions.
- Adds "airflow" property with reference to the existing airflow schema definition
- Adds "profile" property as a string type for NetBox v4.3 compatibility
| @@ -71,6 +74,9 @@ | |||
| }, | |||
| "comments": { | |||
| "type": "string" | |||
| }, | |||
| "profile": { | |||
There was a problem hiding this comment.
I can add the airflow, however the profile option will require some more work
There was a problem hiding this comment.
Hello, what kind of fix would you like? The problem with profile is that it is not standard and can be defined by the user.
There was a problem hiding this comment.
First we would only support the default netbox profiles in this repo, secondly I was having a look the other day, but still not quite sure how the profile attributes are imported/or if that is even possible at this stage, I know in 4.3.4 they added support for importing the module profiles themselves, but currently don't see any information on importing the attributes
There was a problem hiding this comment.
Okay, I have no idea if we can import the attributes, I'll test it. Regarding the default profiles, I'll correct the commit.
harryajc
added
status: revisions needed
This commit add "airflow" and "profile" to moduletype tests to allow using those objects.