Add new folder for module type profiles with an exemplary SFP profile #3393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0lini
force-pushed
the
module-type-profiles
branch
from
0d8e1b2 to
617cbd1
Compare
0lini
changed the title
|
If this is the direction that netbox want to go I would imagine that they would integrate this module profile into netbox, don't think there are really any other module profiles that are missing therefore I don't think this is something that we need to add into this repo |
harryajc
added
the
status: gathering feedback
|
there are a lot of the same sfp modules taking into account different connectors, speeds and wavelengths.. and sometimes it is important to understand the manufacturer.. I don’t think that netbox will fill all this in themselves.. here, a library is most likely needed.. |
|
I created this issue, this will give us an idea what they think. #3393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a new folder, that will contain future module type profiles. Also it contains a profile for SFP transceiver based on one of the latest blog posts.