-
-
Notifications
You must be signed in to change notification settings - Fork 16
fix: Continue pushing RevisionRecords even with errors #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe changes overhaul ParseCareKit’s project structure by renaming several extension files from Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant PCKRevisionRecord
participant Logger
Client->>PCKRevisionRecord: save(options:batchLimit:)
loop For each entity type (Patient, CarePlan, etc.)
PCKRevisionRecord->>PCKRevisionRecord: try save entity
alt Error occurs
PCKRevisionRecord->>Logger: Log error with specific entity type
end
end
PCKRevisionRecord->>PCKRevisionRecord: try self.create(options:)
alt Duplicate error
PCKRevisionRecord->>Logger: Log warning
else Other error
PCKRevisionRecord->>Logger: Log error with details
end
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (16)
💤 Files with no reviewable changes (5)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🔇 Additional comments (17)
✨ Finishing Touches
🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 35.00% 33.12% -1.88%
==========================================
Files 30 25 -5
Lines 2588 2433 -155
==========================================
- Hits 906 806 -100
+ Misses 1682 1627 -55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.