fix(auth): preserve basePath in request URL reconstruction (#13034) #13174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s#13034) Ensure that reqWithEnvURL can correctly restore the API call path when Next.js strips it from incoming requests. Refs: nextauthjs#13034
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@broekema41 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that reqWithEnvURL can correctly restore the API call path when Next.js strips it from incoming requests.
Refs: #13034
☕️ Reasoning
After running into bug #13034 when having a basepath configured in the nextjs config. this variable is unfortunately not easilly exposed and therefor we see a convention in discussions and bug reports using env variable NEXT_PUBLIC_BASE_PATH as it can be available in both the server side and client side.
🧢 Checklist
🎫 Affected issues