Skip to content

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • join some simple examples into one
  • wrap all examples in mock of NcAppContent > NcContent with basic styling (these components can not be used in examples several times on one page)
  • implement open/close logic for all examples
  • fix some typos in comments and docs
  • lint file

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

- join some simple examples into one
- wrap all examples in mock of NcAppContent > NcContent with basic styling (these components can not be used in examples several times on one page)
- implement open/close logic for all examples
- fix some typos in comments and docs
- lint file

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 9.0.0-rc.2 milestone May 13, 2025
@Antreesy Antreesy requested review from susnux and ShGKme May 13, 2025 17:15
@Antreesy Antreesy self-assigned this May 13, 2025
@Antreesy Antreesy added 3. to review Waiting for reviews feature: documentation Related to the documentation feature: app-sidebar Related to the app-sidebar component labels May 13, 2025
@susnux susnux mentioned this pull request May 26, 2025
15 tasks
@susnux susnux modified the milestones: 9.0.0-rc.2, 9.0.0-rc.3 May 28, 2025
@susnux susnux modified the milestones: 9.0.0-rc.4, 9.0.0-rc.5 Jul 16, 2025
@susnux susnux modified the milestones: 9.0.0-rc.6, 9.0.0-rc.7 Aug 21, 2025
@susnux susnux requested a review from CarlSchwan August 24, 2025 14:03
@Antreesy Antreesy modified the milestones: 9.0.0-rc.7, 9.0.0-rc.9 Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component feature: documentation Related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants