Skip to content

refactor(NcButton, NcNoteCard): use status text color for icons and text #7300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

refactor(NcButton, NcNoteCard): use status text color for icons and text #7300

merged 1 commit into from
Aug 19, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 18, 2025

@susnux susnux added 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Aug 18, 2025
@susnux susnux force-pushed the feat/secondary-button-style branch from bac7130 to 6354e66 Compare August 18, 2025 14:49
@nextcloud-command nextcloud-command force-pushed the feat/secondary-button-style branch from 6354e66 to d400072 Compare August 18, 2025 14:52
@susnux susnux mentioned this pull request Aug 18, 2025
Merged
@susnux susnux force-pushed the feat/secondary-button-style branch from d400072 to c9d3af6 Compare August 18, 2025 22:16
@susnux
Copy link
Contributor Author

susnux commented Aug 18, 2025

/update-snapshots

kra-mo
kra-mo requested changes Aug 19, 2025
View reviewed changes
Copy link
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hover/active/border color for success and error actually seem lighter instead of darker (and even for warning, it is quite faint).

I'm not sure if changing those to be darker would be part of this PR? If yes though, then they should be.

@susnux
Copy link
Contributor Author

susnux commented Aug 19, 2025

I'm not sure if changing those to be darker would be part of this PR? If yes though, then they should be.

No its defined in server - also its already fixed there, the variables are just outdated here.

@susnux
refactor(NcButton, NcNoteCard): use status text color for icons and text
9a01c34 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/secondary-button-style branch from 54d132e to 9a01c34 Compare August 19, 2025 08:16
@susnux susnux requested a review from kra-mo August 19, 2025 08:16
@susnux
Copy link
Contributor Author

susnux commented Aug 19, 2025

the variables are just outdated here

Updated now, thus you can recheck if you like

st3iny
st3iny approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had a brief look at the style guide.

@susnux susnux merged commit eb18a60 into main Aug 19, 2025
22 of 25 checks passed
@susnux susnux deleted the feat/secondary-button-style branch August 19, 2025 09:52
@Antreesy Antreesy mentioned this pull request Aug 19, 2025
Merged
@susnux susnux mentioned this pull request Aug 24, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@ShGKme ShGKme ShGKme approved these changes

@artonge artonge Awaiting requested review from artonge

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@kra-mo kra-mo Awaiting requested review from kra-mo

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @st3iny @ShGKme @kra-mo