Skip to content

fix: misleading code examples #13304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

cozykitty
Copy link

added $CONFIG = array ( where it was missing, and would have resultet in an broken instance

☑️ Resolves

  • Fix #…

🖼️ Screenshots

added   $CONFIG = array ( where it was missing, and would have resultet in an broken instance

Signed-off-by: Emma <muelltonnensurfen@gmail.com>
@kesselb
Copy link
Contributor

kesselb commented Jun 25, 2025

Thanks for your pr 👍

I get the idea; however, this only leads to a broken instance one did not read the paragraph above?

cc @joshtrichards @szaimen wdyt?

@cozykitty
Copy link
Author

cozykitty commented Jun 25, 2025

The other thing is... removing <?php from the examples would do that job, as config examples in other documentation pages like

'allowed_admin_ranges' => [
for example. You can't link people from settings/admin/overview to parts of the docs and think they will scroll up ? That's not how anchors are supposed to work. ;-)

Be consistent in docs, to avoid errors.... or avoid errors by clarifying docs.

@kesselb
Copy link
Contributor

kesselb commented Jun 26, 2025

<?php from the examples would do that job

That sounds like the better alternative.

That's not how anchors are supposed to work. ;-)

What anchor are you referring to?

cozykitty and others added 3 commits June 28, 2025 19:13
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Emma <muelltonnensurfen@gmail.com>
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Emma <muelltonnensurfen@gmail.com>
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Emma <muelltonnensurfen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants