-
Notifications
You must be signed in to change notification settings - Fork 110
feat: introduce Section as a new question type #2913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5b7592f
to
7840322
Compare
@keydown.ctrl.enter="onKeydownCtrlEnter" | ||
@update:values="(values) => onUpdate(question, values)" /> | ||
</ul> | ||
<template v-for="(group, groupIndex) in groupedQuestions"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary for the correct operation of postion:sticky when there are several sections.
And also for the future, to add display by separate pages.
7840322
to
f397e03
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
============================================
+ Coverage 44.18% 44.23% +0.04%
- Complexity 1031 1032 +1
============================================
Files 80 80
Lines 3705 3710 +5
============================================
+ Hits 1637 1641 +4
- Misses 2068 2069 +1 🚀 New features to boost your workflow:
|
@AIlkiv @susnux I could imagine that we move the form title to the top bar like in Talk where the chat name is visible there. In Forms we could do it like this:
One problem I can see with your current implementation: If there is a very long description added to a section, you're not able to see the questions anymore. |
I can add max-height + overflow-y: auto |
Signed-off-by: ailkiv <a.ilkiv.ye@gmail.com>
f397e03
to
30e54c4
Compare
@Chartman123 I have already added a height restriction for the block. demo: demo_form2.mp4 |
@Chartman123 If the only problem is the menu overlap, then I suggest we merge this PR and discuss the layout change in a new issue, as it goes beyond the scope of this task. |
@AIlkiv no, we should do this in this PR already before merging. Other than that our main branch is currently ready for the 5.2 release and I'd like to have this in the 5.3 release, so we need to wait until we branch off the stable 5.2 I also don't like the scrollbars that also appear when there's still enough space for the description... So I added Jan and Nimisha from the design team to have a look :) |
@Chartman123 Scroll appears only for long descriptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Some feedback:
- The divider line is too intense / has too much contrast with the background. Does it use var(--color-border)?
- Indeed there is a risk of too large descriptions, but also having intermittent scrollable areas is not so nice. I would suggest to limit the description to 2 rows upon scrolling down, and you can read it in full again by scrolling up, or tapping it will scroll you up to it?
I am not really sure about the implementation as a question type. Its not really a question type but rather some formatting / structuring. |
@susnux In the current context, you are right. But we can expand it and call it “form element” instead of “question.” To add output to pages in the future, we will simply need to add a “separate page” checkbox to the Section settings in the current implementation. |
Based on #2824
@Chartman123 This is an interesting feature because in the future it can be expanded to split one form into pages by section. It can also be expanded to display pages only when a certain condition is met. Much has already been written about this.
Demo:
https://github.com/user-attachments/assets/fc7edb0d-1f24-4493-9c48-0a90dda21052
The only problem I haven't figured out how to solve is that on the mobile layout, the menu partially overlaps the Section (you can see it in the demo).