-
Notifications
You must be signed in to change notification settings - Fork 286
feat(settings): add bordered wrapper to signature editor for clearer … #11789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(settings): add bordered wrapper to signature editor for clearer … #11789
Conversation
Thanks for opening your first pull request in this repository! ✌️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This looks good code-wise. Could you please also post before/after screenshots? I will give this a test of course, but like to have the before/after documented in the PR.
@ChristophWurst Surely I'll put the screenshots through, |
Sure, take your time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GlyphicGuy there is one thing missing: a sign-off. Please see https://github.com/nextcloud/mail/pull/11789/checks?check_run_id=51886414074. Amend the commit, add sign-off and force push. The sign-off is needed so we know your contribution is compatible with the license of this project. |
@ChristophWurst surely, I'll amend the commit message! |
@ChristophWurst i am new to opensource workflows, could you help me with this thing? I'm not quite sure in handling this... |
I think you need a local checkout for this. It can't be done from the Github web UI. |
92e0f0a
to
b8a1da6
Compare
@ChristophWurst i treid following the instructions on the DCO error page, the signed off is solved but i think i messed up some things. I apologies beforehand. kindly guide me if this can be fixed again :( |
f5fbadb
to
56fcbac
Compare
I have redone the rebase for you. Fetch origin and reset your local branch to it. Then try again with the sign off. |
…boundary Signed-off-by: Md Aqudam Azimee <de.la.cruz.01012006@gmail.com>
56fcbac
to
0675a17
Compare
@ChristophWurst did i do it right? |
Yes looks good |
@ChristophWurst is it good to go now? thank you for your patient guidance! |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Yes :) Thank you |
Summary
Adds a bordered wrapper around the signature editor in SignatureSettings.vue so the editable region is visually delimited from surrounding controls like the “Place signature above quoted text” checkbox.
Details
Adds
.signature-editor-wrapper
providing input-like border, radius, and focus ringSuppresses inner CKEditor border to prevent double border
Improves visual clarity and reduces user confusion
Testing
Built frontend (npm run build) – success (only pre-existing warnings)
Ran ESLint & stylelint – no new errors introduced
Fixes #11115