Skip to content

Conversation

GlyphicGuy
Copy link
Contributor

Summary
Adds a bordered wrapper around the signature editor in SignatureSettings.vue so the editable region is visually delimited from surrounding controls like the “Place signature above quoted text” checkbox.

Details
Adds .signature-editor-wrapper providing input-like border, radius, and focus ring
Suppresses inner CKEditor border to prevent double border
Improves visual clarity and reduces user confusion
Testing
Built frontend (npm run build) – success (only pre-existing warnings)
Ran ESLint & stylelint – no new errors introduced

Fixes #11115

Copy link

welcome bot commented Oct 3, 2025

Thanks for opening your first pull request in this repository! ✌️

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good code-wise. Could you please also post before/after screenshots? I will give this a test of course, but like to have the before/after documented in the PR.

@GlyphicGuy
Copy link
Contributor Author

@ChristophWurst Surely I'll put the screenshots through,
I'm new to Open-source, can I take some time?
Thank you.

@ChristophWurst
Copy link
Member

Sure, take your time!

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well!

Thanks again

Before After
Bildschirmfoto vom 2025-10-17 12-58-01 Bildschirmfoto vom 2025-10-17 13-02-20

@ChristophWurst
Copy link
Member

@GlyphicGuy there is one thing missing: a sign-off. Please see https://github.com/nextcloud/mail/pull/11789/checks?check_run_id=51886414074. Amend the commit, add sign-off and force push.

The sign-off is needed so we know your contribution is compatible with the license of this project.

@GlyphicGuy
Copy link
Contributor Author

@ChristophWurst surely, I'll amend the commit message!

@GlyphicGuy
Copy link
Contributor Author

@ChristophWurst i am new to opensource workflows, could you help me with this thing? I'm not quite sure in handling this...
Thank you.
image

@ChristophWurst
Copy link
Member

I think you need a local checkout for this. It can't be done from the Github web UI.

@GlyphicGuy GlyphicGuy force-pushed the feature/signature-editor-border branch 2 times, most recently from 92e0f0a to b8a1da6 Compare October 17, 2025 12:26
@GlyphicGuy
Copy link
Contributor Author

@ChristophWurst i treid following the instructions on the DCO error page, the signed off is solved but i think i messed up some things. I apologies beforehand. kindly guide me if this can be fixed again :(

@ChristophWurst ChristophWurst force-pushed the feature/signature-editor-border branch from f5fbadb to 56fcbac Compare October 17, 2025 12:52
@ChristophWurst
Copy link
Member

I have redone the rebase for you. Fetch origin and reset your local branch to it. Then try again with the sign off.

…boundary

Signed-off-by: Md Aqudam Azimee <de.la.cruz.01012006@gmail.com>
@GlyphicGuy GlyphicGuy force-pushed the feature/signature-editor-border branch from 56fcbac to 0675a17 Compare October 17, 2025 17:55
@GlyphicGuy
Copy link
Contributor Author

@ChristophWurst did i do it right?

@ChristophWurst
Copy link
Member

Yes looks good

@GlyphicGuy
Copy link
Contributor Author

@ChristophWurst is it good to go now? thank you for your patient guidance!

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@ChristophWurst
Copy link
Member

Yes :)

Thank you

@ChristophWurst ChristophWurst merged commit 6f14fd3 into nextcloud:main Oct 18, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Border for account signature editor

2 participants