-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(previews): allow ffmpeg to connect direct for AWS S3 buckets #53634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2adc819
to
e9cdee4
Compare
Updated with a test to see if encryption is enabled on the file, and if so, do not attempt to connect direct. |
e9cdee4
to
14b91cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good codewise, but needs tests.
Not sure why there is the str_starts_with test for http?
The test is needed because ffmpeg doesn't support smb out of the box and I'm not even sure it would work without passing credentials directly on the command line. Same thing for ftp and potentially others. |
14b91cd
to
ebefeb7
Compare
Fixed my commit message and force pushed. |
Hmm, yeah but a provider may also give an http link that does not work without credentials then? It feels a bit arbitrary to me that http* is fine and all else is not. |
Very true. I can add a parameter in addition to the edit: Added. |
Signed-off-by: invario <67800603+invario@users.noreply.github.com>
ebefeb7
to
a581ed6
Compare
Summary
Allow preview generation on AWS S3 buckets by creating a presigned URL for the file and then passing it directly to ffmpeg which is able to handle http/https already. It can locate the moov atom even if it's at the end of the video file and it does not need to retrieve the whole file to do it.
The presigned URL expires after 1 minute which should be more than enough for this purpose.
TODO
Checklist