feat(files_sharing): Toggle display for trusted server shares #53661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
feat/52635/toggle-for-trusted-server-sharing
branch
6 times, most recently
from
3a848ee to
92e64f3
Compare
|
Tested the behavior. It works, but there are a few issues:
Proposals:
|
nfebe
force-pushed
the
feat/52635/toggle-for-trusted-server-sharing
branch
from
92e64f3 to
b95563e
Compare
nfebe
requested review from
susnux,
artonge,
skjnldsv,
provokateurin and
maximelehericy
nfebe
force-pushed
the
feat/52635/toggle-for-trusted-server-sharing
branch
3 times, most recently
from
7ae9b19 to
1c29e9c
Compare
Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
feat/52635/toggle-for-trusted-server-sharing
branch
from
1c29e9c to
6bb5bdc
Compare
|
/compile |
nfebe
commented
Jun 25, 2025
Comment on lines
+197
to
224
| const showFederatedAsInternal = this.config.showFederatedSharesAsInternal | ||
| || this.config.showFederatedSharesToTrustedServersAsInternal | ||
|
|
||
| if (this.isExternal && !this.config.showFederatedSharesAsInternal) { | ||
| shareType.push(...remoteTypes) | ||
| if (this.isExternal) { | ||
| if (!showFederatedAsInternal) { | ||
| shareType.push(...remoteTypes) | ||
| } | ||
| } else { | ||
| shareType = shareType.concat([ | ||
| shareType = [ | ||
| ShareType.User, | ||
| ShareType.Group, | ||
| ShareType.Team, | ||
| ShareType.Room, | ||
| ShareType.Guest, | ||
| ShareType.Deck, | ||
| ShareType.ScienceMesh, | ||
| ]) | ||
|
|
||
| if (this.config.showFederatedSharesAsInternal) { | ||
| ] | ||
| if (showFederatedAsInternal) { | ||
| shareType.push(...remoteTypes) | ||
| } | ||
| } | ||
|
|
||
| if (getCapabilities().files_sharing.public.enabled === true && this.isExternal) { | ||
| shareType.push(ShareType.Email) | ||
| if (this.config.showFederatedSharesToTrustedServersAsInternal) { | ||
| shareType.push(...remoteTypes) | ||
| } | ||
| } |
There was a problem hiding this comment.
One alternative is to let users enter addresses in either input and automatically sort the result into the right section.
Updated code to use last option for, the least friction
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the trust status of federated shares in the Share API, allowing the frontend to filter them based on the new show_federated_shares_to_trusted_servers_as_internal setting.
Usage:
occ config:app:set files_sharing show_federated_shares_to_trusted_servers_as_internal --value true --type booleanScreenshots
Stable31 is trusted server and stable30 is not
Fixes #52635